Repository navigation
Remove the terraform engine from the acceptance CI matrix - #6877
Merged
Merged
Conversation
Collaborator
Integration test reportCommit: aa4e242
Top 15 slowest tests (at least 2 minutes):
|
denik
force-pushed
the
denik/remove-tf-ci-matrix
branch
3 times, most recently
from
September 30, 2026 08:56
9b7e99d to
3015115
Compare
denik
force-pushed
the
denik/remove-tf-ci-matrix
branch
from
September 30, 2026 10:25
3015115 to
ab15880
Compare
2 of 4 tasks
denik
force-pushed
the
denik/remove-tf-ci-matrix
branch
2 times, most recently
from
October 2, 2026 09:34
c9565df to
ac061d5
Compare
denik
marked this pull request as ready for review
October 2, 2026 09:40
denik
requested review from
a team,
jefferycheng1,
kanterov and
lennartkats-db
as code owners
October 2, 2026 09:40
janniklasrose
approved these changes
Oct 2, 2026
janniklasrose
left a comment
janniklasrose
left a comment
Member
There was a problem hiding this comment.
approved based on PR summary & spot checks
pietern
approved these changes
Oct 2, 2026
denik
enabled auto-merge
October 2, 2026 10:16
Drop the global DATABRICKS_BUNDLE_ENGINE matrix and EnvVaryOutput so the acceptance suite is direct-only. The terraform engine code stays; it is removed in a follow-up PR. - acceptance/test.toml: drop EnvMatrix.DATABRICKS_BUNDLE_ENGINE / EnvMatrixExclude.noplantf / EnvRepl. - acceptance/bundle/test.toml: drop EnvVaryOutput and EnvMatrixExclude.dms_needs_direct. - push.yml: drop the terraform cell; direct/directdms cells filter on DMS only. - 57 mixed engine matrices collapsed to ["direct"]; 183 scripts drop the .$DATABRICKS_BUNDLE_ENGINE output suffix. - delete 412 *.terraform.* goldens; rename 468 *.direct.* goldens to plain. - remove 14 terraform-only tests (terraform-specific behavior / rejection paths, obsolete once the engine is gone - their coverage returns as removal-error tests alongside the engine removal); convert cmd/completion and generate/auto-bind to direct-only. Co-authored-by: Isaac <no-reply@databricks.com>
…ine-forced tests Co-authored-by: Isaac <no-reply@databricks.com>
The CI-matrix removal stripped `.$DATABRICKS_BUNDLE_ENGINE` from the scripts' intermediate filenames (e.g. plan_raw.$DATABRICKS_BUNDLE_ENGINE.json -> plan_raw.json) but left the matching Ignore entries as plan_raw.direct.json / plan_raw.terraform.json, so the renamed intermediate was no longer ignored and tripped the "unexpected files" check. Collapse each pair to the plain name. Co-authored-by: Isaac <no-reply@databricks.com>
Dropping DATABRICKS_BUNDLE_ENGINE from the matrix left several scripts still referencing the now-unset variable. Under set -u those errored, and a prior -update baked the "unbound variable" output into their goldens (permissions, recreate-keys, grants, resource_deps), so the tests were green against broken goldens. - Strip the engine suffix from the remaining out.*.$DATABRICKS_BUNDLE_ENGINE.json writes (permissions/_script, recreate-keys/_script, run_as/pipelines/_script). - Drop the direct-only `if [ "$DATABRICKS_BUNDLE_ENGINE" = "direct" ]` guards now that direct is the only engine (volumes/uppercase-name, grants remove-principal), and the dead terraform-only blocks in resource_deps. - Default read_state.py to the direct engine when the variable is unset (terraform only when set explicitly); direct is the CLI default now. - Point the templates/default-python/classic and readplan/lineage-mismatch plan reads at the renamed plain plan files. - Pin generate/auto-bind to the plain DMS variant (bind is unsupported with deployment history), matching its previous single engine run. - Fix user_agent/verify.py to expect engine/direct now that recorded requests are no longer engine-suffixed, and regenerate all affected goldens. Co-authored-by: Isaac <no-reply@databricks.com>
…nd DMS pin Co-authored-by: Isaac <no-reply@databricks.com>
denik
force-pushed
the
denik/remove-tf-ci-matrix
branch
from
October 2, 2026 10:23
2d11a48 to
aa4e242
Compare
Collaborator
Integration test reportCommit: b84661a
10 interesting tests: 6 FAIL, 4 flaky
Top 50 slowest tests (at least 2 minutes):
|
MarioCadenas
added a commit
that referenced
this pull request
Oct 6, 2026
#6877 dropped the default DATABRICKS_BUNDLE_ENGINE matrix, so the test now runs direct-only. Co-authored-by: Isaac <no-reply@databricks.com> Signed-off-by: MarioCadenas <MarioCadenas@users.noreply.github.com>
yiweidai-db
pushed a commit
to yiweidai-db/cli
that referenced
this pull request
Oct 6, 2026
…icks#6941) ## Changes The testserver's stale-read / never-finishing-delete injection (`staleOnceEnabled` in `acceptance/internal/prepare_server.go`) required both `INJECT_STALE_ON_DIRECT=1` and `DATABRICKS_BUNDLE_ENGINE=direct`. Now it only requires `INJECT_STALE_ON_DIRECT=1`. ## Why databricks#6877 removed the terraform engine from the acceptance matrix, so `DATABRICKS_BUNDLE_ENGINE` is no longer set and the injection silently turned off. Running `-update` in that PR then regenerated `postgres_synced_tables/recreate_capped` with a successful recreate (`Recreated postgres_synced_tables.my_table`). The test exists to check the opposite: its section title is "the capped wait times out and the recreate fails". It has been passing on main without checking anything since. With the gate fixed, the golden is back to exactly what databricks#6728 committed: the `DATABRICKS_BUNDLE_RESOURCE_MAX_WAIT` timeout error. The dashboards tests that also set `INJECT_STALE_ON_DIRECT` pass unchanged. ## Tests `TestAccept/bundle/resources/(postgres_synced_tables|dashboards)` This pull request and its description were written by Isaac. Co-authored-by: Isaac <no-reply@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the terraform engine from the acceptance CI matrix so the suite runs direct-only, and drops the now-single-value
DATABRICKS_BUNDLE_ENGINEmatrix pins (usingEnv.DATABRICKS_BUNDLE_ENGINEonly where a test forces a specific engine). The terraform engine code itself is untouched here; it is rejected in #6888 and removed in #6889.This pull request and its description were written by Isaac.