Repository navigation
acc: re-enable stale-read injection without the engine matrix - #6941
Merged
Merged
Conversation
staleOnceEnabled also required DATABRICKS_BUNDLE_ENGINE=direct. Since #6877 dropped the engine matrix, that variable is unset, so the injection was off and recreate_capped's golden was regenerated to a successful recreate instead of the capped-wait timeout it tests. Gate on INJECT_STALE_ON_DIRECT alone. Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
Integration test reportCommit: d915481
Top 3 slowest tests (at least 2 minutes):
|
denik
marked this pull request as ready for review
October 6, 2026 10:03
denik
added a commit
that referenced
this pull request
Oct 6, 2026
Co-authored-by: Isaac <no-reply@databricks.com>
denik
enabled auto-merge
October 6, 2026 11:04
janniklasrose
approved these changes
Oct 6, 2026
denik
added a commit
that referenced
this pull request
Oct 6, 2026
Co-authored-by: Isaac <no-reply@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
The testserver's stale-read / never-finishing-delete injection (
staleOnceEnabledinacceptance/internal/prepare_server.go) required bothINJECT_STALE_ON_DIRECT=1andDATABRICKS_BUNDLE_ENGINE=direct. Now it only requiresINJECT_STALE_ON_DIRECT=1.Why
#6877 removed the terraform engine from the acceptance matrix, so
DATABRICKS_BUNDLE_ENGINEis no longer set and the injection silently turned off. Running-updatein that PR then regeneratedpostgres_synced_tables/recreate_cappedwith a successful recreate (Recreated postgres_synced_tables.my_table). The test exists to check the opposite: its section title is "the capped wait times out and the recreate fails". It has been passing on main without checking anything since.With the gate fixed, the golden is back to exactly what #6728 committed: the
DATABRICKS_BUNDLE_RESOURCE_MAX_WAITtimeout error. The dashboards tests that also setINJECT_STALE_ON_DIRECTpass unchanged.Tests
TestAccept/bundle/resources/(postgres_synced_tables|dashboards)This pull request and its description were written by Isaac.