Repository navigation
acc: stop asserting app job permissions after the first deploy - #6961
Merged
Merged
Conversation
On the direct engine the job permissions and the app (which grants the job permission) can be deployed in either order, so CAN_MANAGE_RUN after the first deploy is order-dependent. The test only removed the direct variant of that output; #6877 renamed the terraform variant to the generic file, so the flaky result is now compared. The second-deploy check, which is what #4309 is about, is unchanged. Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
Integration test reportCommit: 588cb30
Top 8 slowest tests (at least 2 minutes):
|
Co-authored-by: Isaac <no-reply@databricks.com>
denik
marked this pull request as ready for review
October 7, 2026 07:47
denik
enabled auto-merge
October 7, 2026 07:48
Co-authored-by: Isaac <no-reply@databricks.com>
janniklasrose
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a flake in
bundle/apps/job_permissions. On the direct engine the job permissions and the app (which grants the job permission) can be deployed in either order, soCAN_MANAGE_RUNafter the first deploy is order-dependent. The script used to drop the direct variant of that output, but #6877 renamed the terraform variant to the genericout.after_first_deploy.txt, so the flaky result is now compared (seen on #6959'stask test (linux, direct)). The second-deploy check, which is what #4309 covers, is unchanged.This pull request and its description were written by Isaac.