Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cross-built quazip packages (e.g. aarch64) ship CMake exports that still contain the cross sysroot path:
This affects both
QuaZip-Qt5_SharedTargets.cmakeandQuaZip-Qt6_SharedTargets.cmake. Any native build that consumes these exports fails at link time:x86_64 is not affected because it is built natively.
Changes:
${XBPS_CROSS_BASE}from the Qt5/Qt6*_SharedTargets.cmakeinpost_install(cross builds only)bzip2-develtomakedepends: quazip links against bzip2, but it was never declaredbzip2-develtodependsofquazip-develandquazip-qt6-devel, since the exports reference/usr/lib/libbz2.soTesting the changes
quazip-devel/quazip-qt6-develexports; both now point to/usr/lib/libbz2.so.Local build testing