Conversation
Member
|
if upstream says it's not ready, we probably shouldn't do it |
Member
|
I'm with abby, we should stay with qt5 for now |
Contributor
Author
|
@classabbyamp |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switches krita from Qt5 to Qt6/KF6, as suggested in #61486. The two dependent packages move with it:
transition.now/qt6) uses the same tag.vanyossi/gmic, the tarball Krita itself pins in3rdparty_plugins/ext_gmic(checksum matches). This addresses the "gmic-krita is not ready" concern raised in krita: update to 6.0.1 #61486.Other notes:
post_patchrelaxes the SIP ABI pin inSIPMacros.cmake(13.0->13). Without it, the PyKrita bindings fail to build against PyQt6 6.11. The pin is still there in 6.0.4.Qt6GuiPrivate,Qt6WaylandClientPrivate), so it is pinned toqt6-core>=6.11.2and needs a rebuild on every Qt6 bump.This needs a policy decision. Upstream still gates Qt6 builds behind
-DALLOW_UNSTABLE=QT6:The same 6.0.4 tarball still builds as Krita 5.3.4 against Qt5, so keeping Qt5 remains an option. I'd like the maintainers' call on whether Void should ship the Qt6 build. cc @Johnnynator @sgn @classabbyamp
Testing the changes
-Q)Local build testing