Skip to content

feat(stovepipe): Store terminal build ID - #752

Merged
prathshenoy merged 1 commit into
mainfrom
prath.shenoy/stovepipe-terminal-build-marker
Sep 30, 2026
Merged

feat(stovepipe): Store terminal build ID#752
prathshenoy merged 1 commit into
mainfrom
prath.shenoy/stovepipe-terminal-build-marker

Conversation

@prathshenoy

@prathshenoy prathshenoy commented Sep 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary

What:

  • Store the build ID that establishes a request's terminal state.

Why:

  • Make the terminal build direct request state for downstream resolution.

Test Plan

  • Add unit tests.

Revert Plan

  • Revert this PR. No downstream consumer needs the terminal build identity currently.

Issues

Stack

  1. @ feat(stovepipe): Store terminal build ID #752
  2. feat(stovepipe): Persist terminal build ID #754
  3. feat(stovepipe): Record terminal build history #756
  4. feat(stovepipe): Pass terminal build to resolver #757
  5. docs(stovepipe): Document terminal build IDs #758

@prathshenoy
prathshenoy force-pushed the prath.shenoy/stovepipe-terminal-build-marker branch from e0577da to 3c70ced Compare September 29, 2026 00:58
@prathshenoy prathshenoy mentioned this pull request Sep 29, 2026
Merged
1 task done
@prathshenoy
prathshenoy force-pushed the prath.shenoy/stovepipe-terminal-build-marker branch from 3c70ced to 14250bc Compare September 29, 2026 01:18
prathshenoy added a commit that referenced this pull request Sep 29, 2026
@prathshenoy
feat(stovepipe): Look up terminal builds
a2ccd12 
Summary:
**What**:
- Add BuildStore.GetTerminalBuild to retrieve the build that established a request's terminal state.

**Why**:
- Let downstream consumers find the selected build without adding a reverse reference to Request.
- This PR builds on #752, which marks and uniquely selects the terminal build.

Test Plan:
- [x] Add unit tests.

Revert Plan:
- Revert this PR if the terminal-build marker model is not adopted, because this lookup depends on that marker to identify a build.

Jira Issues: None
@prathshenoy
prathshenoy added this pull request to stack #755 September 29, 2026 01:24
@prathshenoy
prathshenoy force-pushed the prath.shenoy/stovepipe-terminal-build-marker branch from 14250bc to 3c70ced Compare September 29, 2026 01:28
@prathshenoy prathshenoy mentioned this pull request Sep 29, 2026
Merged
1 task done
@prathshenoy
prathshenoy force-pushed the prath.shenoy/stovepipe-terminal-build-marker branch from 3c70ced to 8e5cd60 Compare September 29, 2026 01:30
This was referenced Sep 29, 2026
Merged
Merged
@prathshenoy
prathshenoy marked this pull request as ready for review September 29, 2026 13:34
@prathshenoy
prathshenoy force-pushed the prath.shenoy/stovepipe-terminal-build-marker branch from 8e5cd60 to d358f0b Compare September 29, 2026 17:15
@prathshenoy prathshenoy changed the title feat(stovepipe): Mark the terminal outcome build feat(stovepipe): Mark request-terminating build Sep 29, 2026
@prathshenoy
prathshenoy force-pushed the prath.shenoy/stovepipe-terminal-build-marker branch 2 times, most recently from d7d54e4 to 4ab6eaf Compare September 29, 2026 17:27
mnoah1
mnoah1 approved these changes Sep 29, 2026
View reviewed changes
Comment thread stovepipe/extension/storage/mysql/schema/build.sql Outdated
Comment thread stovepipe/extension/storage/mysql/schema/build.sql
@prathshenoy
prathshenoy force-pushed the prath.shenoy/stovepipe-terminal-build-marker branch from 4ab6eaf to 2ddf455 Compare September 29, 2026 22:22
@prathshenoy prathshenoy changed the title feat(stovepipe): Mark request-terminating build feat(stovepipe): Store terminal build ID Sep 29, 2026
@prathshenoy
prathshenoy force-pushed the prath.shenoy/stovepipe-terminal-build-marker branch from 2ddf455 to ab6f957 Compare September 29, 2026 22:28
@prathshenoy
feat(stovepipe): Store terminal build ID
e04151e 
**What**:
- Add the terminal build identity to each completed request.
- Persist the identity with the request lifecycle state.

**Why**:
- Make the selected build directly available to request consumers.
- Keep the schema change additive and migration-compatible.
@prathshenoy
prathshenoy force-pushed the prath.shenoy/stovepipe-terminal-build-marker branch from ab6f957 to e04151e Compare September 29, 2026 22:30
@prathshenoy
prathshenoy added this pull request to the merge queue Sep 30, 2026
Merged via the queue into main with commit df3bfea Sep 30, 2026
16 checks passed
@behinddwalls
behinddwalls deleted the prath.shenoy/stovepipe-terminal-build-marker branch September 30, 2026 00:10
@prathshenoy prathshenoy mentioned this pull request Oct 1, 2026
Closed
1 task done
behinddwalls pushed a commit to behinddwalls/submitqueue that referenced this pull request Oct 5, 2026
@prathshenoy
feat(stovepipe): Persist terminal build ID (uber#754)
a8368f9 
## Summary

**What**:
- Persist the terminal build ID together with a request's terminal
state.

**Why**:
- Ensure the first terminal build also becomes the request’s recorded
terminal build.

## Test Plan

- [x] Add unit tests.

## Revert Plan

- Revert this PR. It only stops terminal transitions from populating the
nullable field; existing request state remains unchanged.

## Issues

-
[CODEM-544](https://linear.app/uber/issue/CODEM-544/pass-terminal-build-to-project-resolver)

## Stack

1. uber#752
1. @ uber#754
1. uber#756
1. uber#757
1. uber#758
behinddwalls pushed a commit to behinddwalls/submitqueue that referenced this pull request Oct 5, 2026
@prathshenoy
feat(stovepipe): Record terminal build history (uber#756)
c3e14e2 
## Summary

**What**:
- Record the terminal build ID with a request's terminal history when a
build establishes the state.

**Why**:
- Preserve durable history showing which build established the request’s
final state.

## Test Plan

- [x] Add unit tests.

## Revert Plan

- Revert this PR. Terminal history is supplementary and does not change
request state or project resolution.

## Issues

-
[CODEM-544](https://linear.app/uber/issue/CODEM-544/pass-terminal-build-to-project-resolver)

## Stack

1. uber#752
1. uber#754
1. @ uber#756
1. uber#757
1. uber#758
behinddwalls pushed a commit to behinddwalls/submitqueue that referenced this pull request Oct 5, 2026
@prathshenoy
feat(stovepipe): Pass terminal build to resolver (uber#757)
1c5b572 
## Summary

**What**:
- Provide the terminal build ID when resolving project validation
results.

**Why**:
- Let repository-specific resolution use artifacts from the build that
established the request state.

## Test Plan

- [x] Add unit tests.

## Revert Plan

- Revert this PR. It only stops project resolution from receiving the
terminal build ID; request state and history remain unchanged.

## Issues

-
[CODEM-544](https://linear.app/uber/issue/CODEM-544/pass-terminal-build-to-project-resolver)

## Stack

1. uber#752
1. uber#754
1. uber#756
1. @ uber#757
1. uber#758
behinddwalls pushed a commit to behinddwalls/submitqueue that referenced this pull request Oct 5, 2026
@prathshenoy
docs(stovepipe): Document terminal build IDs (uber#758)
6056310 
## Summary

**What**:
- Document how a terminal build ID is stored on a request and provided
to project resolution.

**Why**:
- Keep the RFC aligned with the request-side terminal-build behavior.

## Test Plan

- [x] Ask an agent to find inconsistencies between the docs and the
code.

## Revert Plan

- Revert this PR. The changes in this PR include documentation only.

## Issues

-
[CODEM-544](https://linear.app/uber/issue/CODEM-544/pass-terminal-build-to-project-resolver)


## Stack

1. uber#752
1. uber#754
1. uber#756
1. uber#757
1. @ uber#758

This branch was successfully deployed

1 active deployment
stack-rebase — e04151e0 Deployed Sep 30, 2026 by prathshenoy via Rebase Stack #542
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mnoah1 mnoah1 mnoah1 approved these changes
@behinddwalls behinddwalls Awaiting requested review from behinddwalls behinddwalls is a code owner
@sbalabanov sbalabanov Awaiting requested review from sbalabanov sbalabanov is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@prathshenoy @mnoah1