feat(skills): add thin pull-request lifecycle router - #692
Conversation
ss-o
left a comment
There was a problem hiding this comment.
Fallback review under ADR-0026: maintainer elected, no Copilot request on f9cc6a2
Findings
No actionable findings in the latest commit or the complete two-file diff. Reviewed under the canonical code-review skill and generic review criteria.
Note
This is a maintainer-elected self-review, not an independent review or approval to merge.
Validation
- Source checks: skill frontmatter, public policy, routing, approved provenance, ADR and Zsh-policy validators passed. Trunk 1.25.0 passed on both changed files.
- Tests: 250 passed in the tracked-source snapshot; its one history-dependent case passed separately in the actual checkout. Hosted instruction validation passed; hosted Org Routing ran the history-dependent suite without skips.
- CI: All 12 checks passed on the reviewed HEAD. Annotations contain only recorded link-cache permission warnings and Ubuntu migration notices.
- Metadata: #668 is open and Project 28
In Progress, withtype:maintenanceandarea:meta. This draft hastype:feature,area:metaand Project 28In Review.
Checklist verdicts and evidence
- Correctness: pass. The entry point requires the local canonical PR runbook or its public source and stops external writes if neither is accessible. It covers lifecycle routing, current-HEAD evidence and handoff without replacing substantive code review.
- Authority and security: pass. Git, publication, review and metadata mutations require approved scope. Tool or skill availability grants no authority. No credentials, settings, workflow permissions or executable shell behavior change.
- Compatibility: pass for this scope. One optional advisory manifest entry uses established consumers and the
pull-requesttask. Existing entries, mandatory routing, dependencies and approved revisions are unchanged. No public API, Zsh compatibility floor or plugin lifecycle changes. - Maintainability: pass. The runbook owns branch, traceability, review and post-merge procedures. The skill adds no copied branch patterns, fallback markers or exemption rules. Its description directs code-only review to the existing review skill.
- Coverage: pass. Reviewed the complete published diff against the approved scope, resolved canonical owners, inspected current CI logs and annotations, and confirmed zero existing review threads. The canonical review skill validates and matches its approved source content.
Limits and follow-up
Runtime discovery and downstream delivery are unverified and outside this PR. Manifest consumers declare intent, not delivery. No independent review was performed.
Keep #668 open for Project tracker routing, delivery, reference-integrity checks and the retained issue-reference audit. Those follow-ups are recorded in the issue and workspace notes. This scoped phase is ready for the maintainer's merge decision.
Summary
Refs #668. Agents can discover the review skill but have no shared entry point for the complete PR lifecycle. Add the thin
pull-requestrouter requested by ADR-0032 and #668, with a discriminating description and short gates for current-HEAD evidence, authority and handoff.The canonical PR runbook retains the procedures, branch rules, traceability decisions, review exceptions, merge and post-merge requirements. The new skill reads that runbook locally or from its public source and stops external writes when both are unavailable. Substantive review remains under
code-review. This avoids another private or self-contained copy of the procedure.Instruction impact
runbooks/pull-requests.mdowns the lifecycle;code-reviewowns substantive review execution under the runbook, and ADR-0032 owns the architecture.skill-pull-request, scoped to thepull-requesttask, with the established supported-consumer list. No private manifest or downstream routes change.Verification
check --no-fixon both changed files: passed.f9cc6a2d. Current-HEAD fallback review posted and read back; no actionable findings. GitHub rendering checked at desktop and mobile widths, expanded and collapsed without horizontal overflow.Compatibility and follow-up
This is a two-file canonical-source change. No dependency, enforcement, approved-pin, downstream install, credentials or settings change. The public runbook fallback supports repositories lacking a local copy. The code-review-only exclusion keeps this lifecycle entry point from replacing the existing review skill.
Keep #668 open: Project tracker routing, runtime delivery, reference-integrity checks and the retained issue-skill reference audit remain. No new project direction or implementation of those follow-ups is included.
Agent handoff
The local router phase is implemented and the maintainer authorized reopening #668, its prepared progress note, routine issue/PR labels and Project progress, commit/push, draft publication and fallback review without a Copilot request. Hosted CI passed and the current-HEAD fallback review is posted with no actionable findings. The issue is open and In Progress; this draft is In Review. Remaining #668 work stays recorded for later scoped phases. Stop for the maintainer's merge decision; no pins, downstream installs or later-phase implementation are included.