Repository navigation
Conversation
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #1289
Scan targets checked: wolfssh-src, wolfssh-bugs
Coverage: 2 of 3 in-scope changed file(s) opened by the reviewer; not opened: src/internal.c
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
Review tier: Lite
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Crypto feature gating and its CI configurations warrant final human verification.
Review effort: Balanced
Findings: None
What changed in this PR
This PR makes wolfSSH disable ML-DSA when all three ML-DSA levels are disabled, with checks for the resulting configuration.
Changes:
- Derives
WOLFSSH_NO_MLDSAfrom the three level-disable macros. - Adds a unit check and CI configurations for disabled levels.
- Guards ML-DSA-44 test data and updates the feature documentation.
| File | Description |
|---|---|
wolfssh/internal.h |
Derives the all-levels-disabled macro. |
tests/unit.c |
Checks disabled-level behavior and guards ML-DSA-44 test data. |
src/internal.c |
Documents the derived macro. |
.github/workflows/mldsa-composite-config.yml |
Adds CI configurations and output checks. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| testResult = testResult || unitResult; | ||
| #endif /* WOLFSSH_NO_MLDSA_COMPOSITES */ | ||
| #endif | ||
| #if defined(WOLFSSH_NO_MLDSA44) && defined(WOLFSSH_NO_MLDSA65) && \ |
There was a problem hiding this comment.
Use #ifndef WOLFSSH_NO_MLDSA
With 44, 65 and 87 all off, keygen and key loading still took ML-DSA.
9851ab2 to
9ef1116
Compare
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #1289
Scan targets checked: wolfssh-src, wolfssh-bugs
Coverage: 1 of 1 in-scope changed file(s) opened by the reviewer
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
Review tier: Lite
Defined WOLFSSH_NO_MLDSA when all three level macros are set. Added test_MlDsaLevelsDisabled to ensure keygen runs WS_NOT_COMPILED when all levels are off, and wraped ML-DSA-44 keys in macro checks. Exercised no-mldsa44 and no-levels in CI.