Skip to content

fix(app,script): ship the dashboard without the toolchain that built it - #399

Merged
vishnuv688 merged 7 commits into
mainfrom
fix/cheap-published-install
Sep 29, 2026
Merged

vishnuv688 merged 7 commits into
mainfrom
fix/cheap-published-install

Conversation

@vishnuv688

@vishnuv688 vishnuv688 commented Sep 29, 2026 •

Copy link
Copy Markdown
Member

What & why

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Polish (an improvement to an existing feature)
  • Breaking change (existing behavior changes for users)
  • Documentation
  • Internal (build, CI, dependencies, tooling)

Packages touched

  • shared (types and contracts)
  • core (framework-agnostic capture/reporting)
  • elements (published element/snapshot API — @wdio/elements)
  • service (WebdriverIO adapter)
  • nightwatch-devtools (Nightwatch adapter)
  • selenium-devtools (Selenium adapter)
  • selenium-devtools-py (Selenium Python adapter)
  • backend (server)
  • app (UI)
  • script (page-injected runtime)
  • trace (Trace mode)

Notes for reviewers

Screenshots / recordings

@greptile-apps

greptile-apps Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

[Medium risk] Moves build libraries to dev dependencies and fixes UI state replay.

The PR appears safe to merge; no new actionable issue or outstanding previous finding was identified.

Findings

  1. P1 Incomplete cache blocks capture ▶

Summary

The PR reduces the dashboard’s published dependency footprint, adds a one-time backend installation command for the Python adapter, preserves Run-all commands across Python reruns, and corrects replay of boolean markup attributes. The latest changes address the three previous findings: boolean markup now uses attribute presence, the cached server entry comes from package metadata, and a cached backend that fails to start falls back to npx.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A[Python adapter] --> B{Backend available?}
  B -->|Running backend| C[Attach]
  B -->|Installed copy| D[Start cached server]
  D -->|Startup fails| E[Fall back to npx]
  B -->|No installed copy| E
  D -->|Starts| F[Dashboard capture]
  E -->|Starts| F
Loading

Reviews (3) · Last reviewed commit: "fix(selenium-devtools-py): never get stu..."

Comment thread packages/selenium-devtools-py/src/selenium_devtools/backend_install.py Outdated
Comment thread packages/app/src/components/browser/vnode-transform.ts Outdated
@vishnuv688
vishnuv688 merged commit 0d3f87c into main Sep 29, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant