Repository navigation
Upgrade Vortex to 0.87.0 and DataFusion to 55.1.0 together - #16
Merged
Merged
Conversation
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade Vortex to 0.87.0 and DataFusion/DataFusion CLI to 55.1.0 together, replacing #13 and #14. Updating either dependency independently mixes DataFusion 54 and 55 and fails to compile the Vortex file format registration.
Adapt the batch-size setting to
ConfigNonZeroUsize, preserve upstream's stdin SQL guard, and declare the Rust 1.95 minimum required by Vortex. RegenerateCargo.lockand exercise an explicit batch size in the existing SQL integration test.Group Vortex and DataFusion updates in Renovate, including major upgrades, to avoid splitting this dependency pair across future PRs.
CI failure analysis: both original PRs fail
Check buildwithVortexFormatFactory: FileFormatFactorynot satisfied because two versions ofdatafusion_datasourceare resolved. #14 additionally reportsexpected ConfigNonZeroUsize, found usize. The latest main-branch run passed; these failures correlate directly with the independent dependency updates.Validation: targeted Cargo dependency update completed successfully. Local builds and tests were not run; this PR's CI runs formatting, the locked build, and tests.