Repository navigation
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The configuration, tests, documentation, and generated bundle consistently implement SQL Server 2025 cumulative updates.
0 open findings
What changed in this PR
Adds cumulative-update support for SQL Server 2025, including the default latest version.
Changes:
- Configures the official SQL Server 2025 update page.
- Adds SSEI update-installation and version-registry tests.
- Updates documentation and generated artifacts.
| File | Description |
|---|---|
src/versions.ts |
Adds the 2025 cumulative-update URL. |
test/versions.ts |
Verifies supported update configurations. |
test/install.ts |
Tests updates during SSEI installation. |
README.md |
Documents update-supported versions. |
lib/main/index.js |
Rebuilds the action bundle. |
lib/main/index.js.map |
Updates the bundle source map. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Setup exits with 3010 when it succeeds but wants a reboot, which a runner can't do mid-job. Previously @actions/exec rejected that as a failure even though the instance was installed. Log a warning instead and continue, letting the wait-for-ready check confirm the instance is usable. Any other non-zero exit code still fails the action. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Microsoft now publishes cumulative updates for SQL Server 2025, so configure its update URL. Because `latest` resolves to 2025, users with `install-updates: true` on the default version previously got no cumulative update at all; they now get the latest CU applied during setup. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dhensby
force-pushed
the
feat/sql-2025-cumulative-updates
branch
from
October 9, 2026 09:28
27db4bb to
ca80328
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Microsoft now publishes cumulative updates for SQL Server 2025 at https://www.microsoft.com/en-us/download/details.aspx?id=108788, so this adds it as the 2025
updateUrland drops the stale "updateUrl can be added once…" comment.Because
latest(the defaultsqlserver-version) resolves to 2025, anyone usinginstall-updates: trueon the default version has been getting no CU at all. With this change they get the latest CU (currently KB5122048, 17.0.5005.3) applied during setup. That's a change in what users get by default, hencefeat:.Builds on #295 (the reworked CU page resolver). I ran that resolver against the live 2025 page: it resolves to exactly one x64 installer,
https://download.microsoft.com/download/10a21237-8b59-4fcd-b878-bfe8fcabdc7a/SQLServer2025-KB5122048-x64.exe.Setup exit code 3010
With the CU applied, setup on
windows-2025runners finishes withFinal result: Passed but reboot requiredand exit code 3010. Patch Level is 17.0.5005.3, so the update itself installed fine.@actions/exectreated that as a failure. A separatefix:commit now treats 3010 as success with a warning and lets wait-for-ready confirm the instance is up. Any other non-zero exit code still fails the action. This applies to every version, not just 2025.Changes
src/versions.ts: 2025 entry gets itsupdateUrltest/versions.ts: asserts an update URL is configured for 2016 through 2025test/install.ts: covers an SSEI install withinstall-updates: true(passes/UPDATEENABLED=1and/UpdateSource). Nothing tested that combination beforeREADME.md: says which versions get cumulative updatessrc/install.ts: setup exit code 3010 logs a warning and continues; other non-zero codes throw. Tests cover both, and README + copilot-instructions document itlib/: rebuiltVerification
npm run lint:fix,npm test(155 passing),npm run buildrunaction(sql-2025/sql-latestwithinstall-updates: true): checking that setup picks up KB5122048 and that SQL Server reports 17.0.5005.3🤖 Generated with Claude Code