Repository navigation
[symfony] Skip enums, closures and exception classes in "NoNullableServiceInConstructorRule" - #333
Merged
TomasVotruba merged 1 commit intoOct 2, 2026
Conversation
…rviceInConstructorRule" A nullable enum or Closure parameter is a value, not a container service, so it is left alone like DateTimeInterface and Throwable already are. An exception class is built with "new" at the throw site, so its constructor carries error context (for example a nullable response), not services; it is skipped whole. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
|
Legit, thank you |
TomasVotruba
enabled auto-merge (squash)
October 2, 2026 09:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NoNullableServiceInConstructorRulereports some nullable constructor parameters that are values, not container services. This PR skips three more of them, in the same way the rule already skipsThrowableandDateTimeInterfaceparameters.1. Enum parameters
An enum is never a container service, so
?SomeEnum $statusis an optional value:2.
ClosureparametersAn optional callback such as
?Closure $handler = nullis a value too.3. Exception classes
An exception is built with
newat the throw site, never by the container. Its constructor carries error context, for example a nullable HTTP response:The rule now skips a class that is itself a
Throwable, in the same way it skips the\Exception\namespace.Each case has a fixture in
NoNullableServiceInConstructorRuleTest. All three were reported before the change. The full suite, ECS, PHPStan and Rector pass.