Skip to content

chore: clean-up - #15685

Merged
kgryte merged 5 commits into
developfrom
philipp/fix-commit-review-2026-09-30
Sep 30, 2026
Merged

kgryte merged 5 commits into
developfrom
philipp/fix-commit-review-2026-09-30

Conversation

@Planeshifter

@Planeshifter Planeshifter commented Sep 30, 2026 •

Copy link
Copy Markdown
Member

Description

What is the purpose of this pull request?

This pull request:

  • Follow-up fixes for commits merged to develop between 2026-09-29T22:37:35-07:00 (d374b2425) and 2026-09-30T04:45:58-07:00 (59459177f).

number/int32/base/signbit

  • Fix number/int32/base/signbit package description (4b0f1ac): package.json described a "double-precision floating-point number", copied from float64/base/signbit; now "signed 32-bit integer". Also fix lib/index.js @module example, which redeclared var bool three times; subsequent calls now reassign bool.

math/base/special/digammaf

  • Update license in math/base/special/digammaf/package.json to "Apache-2.0 AND BSL-1.0" (5d3c88e). The implementation is ported from Boost and carries a BSL notice in src/main.c and lib/main.js, so the license now matches math/base/special/digamma.

blas/ext/base/sleft-pad-edge

  • Fix $ExpectError cases for unsupported argument counts in blas/ext/base/sleft-pad-edge/docs/types/test.ts (lines 135 and 279), introduced in 144f892 (merged via c68741a/56dd981e3). The calls passed an undeclared out, so the directive passed on the undefined identifier and not on the arity check; replace with y, matching dleft-pad-edge.

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Validation

  • Checked: stdlib style guide compliance (docs/style-guides) against sibling reference packages (two independent passes), plus two independent bug scans of the union diff. The bug scans compiled the new C sources for digammaf and polygamma, compared their output against the JS implementations, and ran the added and modified JS tests; no runtime bugs were found.
  • Every fix was re-verified against the file at the tip of develop and is confined to lines added in the review window.
  • Deliberately excluded (these need interpretation, or the fix belongs outside this diff): the "strictly ascending or descending" wording in blas/ext/base/gindex-of-greater-than-sorted docs, and the stale ascending-only note in the bot-generated blas/ext/base/docs/types/index.d.ts, which will be fixed on regeneration.
  • An initial max-len directive added to ndarray/base/kernels/generic/ternary-strided1d/unblocked/lib/{9d,10d}.js was reverted: the line is within max-len, and ESLint flagged the directive as unused.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was written primarily by Claude Code as part of an automated daily review of commits merged to develop. A maintainer should audit it before it is marked ready for review.


🤖 Generated with Claude Code

https://claude.ai/code/session_015wcdAbXdeq97ExWZtcLi47

…/signbit`

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015wcdAbXdeq97ExWZtcLi47
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015wcdAbXdeq97ExWZtcLi47
…peScript tests

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015wcdAbXdeq97ExWZtcLi47
…ernary-strided1d/unblocked`

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015wcdAbXdeq97ExWZtcLi47
…eneric/ternary-strided1d/unblocked`"

The line does not exceed `max-len`, so ESLint flags the directive as unused.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015wcdAbXdeq97ExWZtcLi47
@stdlib-bot

stdlib-bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/sleft-pad-edge $\\color{green}384/384$
$\\color{green}+100.00\\%$
$\\color{green}18/18$
$\\color{green}+100.00\\%$
$\\color{green}4/4$
$\\color{green}+100.00\\%$
$\\color{green}384/384$
$\\color{green}+100.00\\%$
math/base/special/digammaf $\\color{red}558/563$
$\\color{green}+99.11\\%$
$\\color{red}37/39$
$\\color{green}+94.87\\%$
$\\color{green}6/6$
$\\color{green}+100.00\\%$
$\\color{red}558/563$
$\\color{green}+99.11\\%$
number/int32/base/signbit $\\color{green}95/95$
$\\color{green}+100.00\\%$
$\\color{green}5/5$
$\\color{green}+100.00\\%$
$\\color{green}1/1$
$\\color{green}+100.00\\%$
$\\color{green}95/95$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

@kgryte
kgryte marked this pull request as ready for review September 30, 2026 19:11
@kgryte
kgryte requested a review from a team September 30, 2026 19:11
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Sep 30, 2026
@kgryte kgryte changed the title chore: fix issues in commits merged to develop on 2026-09-30 chore: clean-up Sep 30, 2026
@kgryte
kgryte merged commit 7728021 into develop Sep 30, 2026
34 checks passed
@kgryte
kgryte deleted the philipp/fix-commit-review-2026-09-30 branch September 30, 2026 19:12
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Sep 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants