Skip to content

Add option to display observed data as points in ppc_km_overlay() and ppc_km_overlay_grouped() - #560

Merged
jgabry merged 13 commits into
stan-dev:masterfrom
Sakuski:ppc_km_overlay-dots
Sep 21, 2026
Merged

jgabry merged 13 commits into
stan-dev:masterfrom
Sakuski:ppc_km_overlay-dots

Conversation

@Sakuski

@Sakuski Sakuski commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Fixes #558

Declaration of AI Usage

AI-based tools were used to help to create some parts of the code. All AI modifications were carefully reviewed manually.

@codecov-commenter

codecov-commenter commented Sep 21, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.75%. Comparing base (e651a2a) to head (66e42c6).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #560   +/-   ##
=======================================
  Coverage   98.75%   98.75%           
=======================================
  Files          36       36           
  Lines        6966     7014   +48     
=======================================
+ Hits         6879     6927   +48     
  Misses         87       87           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jgabry jgabry left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the PR!

R cmd check failed only because it needed the .Rd file regenerated after adding the new argument. I made a couple of very small edits and will merge this when CI passes. Thanks again.

@jgabry
jgabry merged commit f8fdd91 into stan-dev:master Sep 21, 2026
6 checks passed
@jgabry

jgabry commented Sep 21, 2026

Copy link
Copy Markdown
Member

@Sakuski I forgot to ask you to do it as part of this PR, but if you want can you make a new PR adding yourself as a contributor in the DESCRIPTION file? I think this is your third helpful PR, so happy to add you if you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Option to visualize event times and censoring times as dots in ppc_km_overlay()

3 participants