Add option to display observed data as points in ppc_km_overlay() and ppc_km_overlay_grouped() - #560
Merged
Merged
Conversation
…to ppc_km_overlay-dots
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #560 +/- ##
=======================================
Coverage 98.75% 98.75%
=======================================
Files 36 36
Lines 6966 7014 +48
=======================================
+ Hits 6879 6927 +48
Misses 87 87 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jgabry
approved these changes
Sep 21, 2026
jgabry
left a comment
Member
There was a problem hiding this comment.
Looks good, thanks for the PR!
R cmd check failed only because it needed the .Rd file regenerated after adding the new argument. I made a couple of very small edits and will merge this when CI passes. Thanks again.
Member
|
@Sakuski I forgot to ask you to do it as part of this PR, but if you want can you make a new PR adding yourself as a contributor in the DESCRIPTION file? I think this is your third helpful PR, so happy to add you if you want. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #558
Declaration of AI Usage
AI-based tools were used to help to create some parts of the code. All AI modifications were carefully reviewed manually.