Repository navigation
Conversation
The modal template and its parameter list now accept color and visible. color applies a Tabler background and the same contrasting foreground used by a colored toast to the header only, mapping white to the light foreground and adding text-reset on the title; an empty or omitted color adds no classes, and the body and footer are left alone. visible sets data-modal-visible and does not emit a script. Client init then shows the last marked modal through Bootstrap unless the URL hash already names a different modal, removes every marker so a later fragment load does not open an earlier dialog or reopen one the user closed, and leaves the address unchanged. Fixes sqlpage#1258
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The modal template and its parameter list now accept color and visible. A modal could not be given a header color, and it stayed closed when the page loaded.
Tests for this live in
tests/end-to-end/fixtures/modal/index.sqlandtests/end-to-end/fixtures/modal/test.ts.Fixes #1258