Repository navigation
Conversation
21c is an older innovation release; 23ai matches the database server used in CI and may have fixed or changed the finiSqora client cleanup path. No public reports of the bccFreeProcess exit deadlock were found (finiSqora appears only in an unrelated 2020 iRODS crash stack). Verified locally: all 90 integration tests pass in ~16s with the 23.26.0.0.0 client against Oracle 23.26.2, with a clean process exit.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Collaborator
Author
|
Superseded by #1525: rebuilt as a clean PR against main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacks on #1522. Bumps the Oracle test client from 21.21.0.0.0 to 23ai (23.26.0.0.0), which matches the database server used in CI (gvenzl/oracle-free:23.x). 21c is an older innovation release, and the 23ai client may have fixed or changed the
finiSqoracleanup path behind the exit hang.The install script is now parameterized (
oracle_version/oracle_build/oracle_dir/oracle_driver/oracle_so) so the next bump is a few lines.Validation (local, Fedora 44): installed the client via the new script, started the compose
oracleservice, built with--features odbc-static, ran the suite as CI does (--test-threads=2,MALLOC_CHECK_=3,MALLOC_PERTURB_=10): 90 passed, 0 failed in ~16s, clean process exit.Caveat: this run includes #1522's harness fix (pools/Statements closed before runtime shutdown), so it shows the suite is green and exits cleanly on 23ai — it does not isolate whether the raw destructor path is fixed in 23ai, since the hang precondition (sessions open at exit) no longer occurs.
Deadlock literature search: no public reports of this exact hang found.
bccFreeProcesshas zero web hits;finiSqoraappears only in iRODS#5234 (2020, 11g client, a crash stack during memory exhaustion — not a hang) and an old ODBC doc page. Consistent with the signature being easy to misattribute to a test hang.