Skip to content

fix(tables): stop the fold sweep from starting a page query past its budget - #8766

Merged
TheodoreSpeaks merged 1 commit into
stagingfrom
fix/fold-sweep-page-deadline
Oct 7, 2026
Merged

TheodoreSpeaks merged 1 commit into
stagingfrom
fix/fold-sweep-page-deadline

Conversation

@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator

Summary

  • foldPendingTableRowChanges checked its budget only before each table, so after a page of folds it fetched the next page of pending tables even when the 45 s budget was already spent. It now checks before every page fetch too, so a sweep never starts new work past its deadline; tables left over fold on the next minute's run

Type of Change

  • Bug fix

Testing

  • lib/table/row-changes.integration.ts on a migrated DB (6 passed), bun run lint, check:audits

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

🤖 Generated with Claude Code

https://claude.ai/code/session_01CJxC2fgucGVpT59RV5Z7xv

@vercel

vercel Bot commented Oct 7, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Oct 7, 2026 10:01pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 4/5

[Medium risk] Adjusts budget check timing in a background table-processing loop.

The PR appears safe to merge, with non-blocking feedback to protect the deadline fix with a regression test.

Findings

  1. P2 Deadline check lacks regression coverage ▶

Summary

foldPendingTableRowChanges now checks its deadline before fetching each page. Both deadline exits share outOfBudget, which preserves the existing counters and warning.

  • Pending work remains available to later sweeps.
  • Non-blocking feedback: add a regression test for the deadline between pages.

Reviews (1) · Last reviewed commit: "fix(tables): stop the fold sweep from st..." · Reviewed by Greptile

Comment thread apps/sim/lib/table/row-changes.ts
@TheodoreSpeaks
TheodoreSpeaks merged commit 96090ca into staging Oct 7, 2026
47 checks passed
@TheodoreSpeaks
TheodoreSpeaks deleted the fix/fold-sweep-page-deadline branch October 7, 2026 22:23

This branch was previously deployed

1 inactive deployment
Preview — 362a5af2 Deployed Oct 7, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant