Skip to content

fix(code-placeholders): skip heredoc bodies when scanning shell quote context - #8603

Merged
waleedlatif1 merged 1 commit into
stagingfrom
fix/shell-heredoc-quote-desync
Oct 3, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
fix/shell-heredoc-quote-desync

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Shell quote-context scanning now skips heredoc bodies, so quote characters in body text no longer desync quoting for the code after them
  • Unquoted heredoc bodies are scanned on their own for env reads

Type of Change

  • Bug fix

Testing

  • Added regression tests in compiler.test.ts (fail on the pre-fix code); code-placeholders suite passes
  • bun run lint, bun run type-check, bun run check:audits, docs-manifest:check, block-registry check

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Oct 3, 2026 7:25pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium risk] Fixes shell quote context scanning around heredoc blocks.

The PR appears safe to merge based on the reviewed changes.

Summary

The PR prevents heredoc body text from changing the quote context used to scan subsequent shell code. It also scans unquoted heredoc bodies separately for environment reads and adds regression tests for both behaviors.

Reviews (2) · Last reviewed commit: "fix(code-placeholders): skip heredoc bod..."

Comment thread apps/sim/lib/execution/code-placeholders/shell.ts
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit f67222e into staging Oct 3, 2026
33 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/shell-heredoc-quote-desync branch October 3, 2026 21:16

This branch was previously deployed

1 inactive deployment
Preview — 0ca02e53 Deployed Oct 3, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant