fix(mothership): stop duplicating chat resource tabs in workspace chats

[waleedlatif1]

Summary

• Chat resource tabs are keyed by workspaceId when it's present, and workspace chats leave it out (message tab attachments, the sandbox transport, the client). Three server writers stamped it unconditionally, so the same workflow/file/table got stored and rendered as two tabs
• Agent CLI effects now stamp the workspace only in organization chats, matching sandbox-resource-transport
• open_resource no longer emits workspaceId; the tool executor already stamps the target workspace for organization chats
• handleResourceSideEffects takes the chat owner and stamps the workspace only in organization chats
• Existing duplicated rows are left as-is

Type of Change

• Bug fix

Testing

• resource-owner.test.ts now asserts a workspace-chat agent effect and open_resource produce the same key as an open tab; it fails on the pre-fix code
• bun run --cwd apps/sim test on lib/mothership/agent-cli, tools/server/open-resource, tools/registry, request/tools (562 passed); wider lib/mothership + copilot/mothership routes + home stream hooks (3,280 passed)
• bun run type-check, bun run lint, check:audits (54 audits), docs-manifest:check
• resources.test.ts covers both owners of handleResourceSideEffects; the workspace-chat case fails with the guard reverted

Checklist

• Code follows project style guidelines
• Self-reviewed my changes
• Tests added/updated and passing (new tests pass the test-audit authoring gate)
• No new warnings introduced
• I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
docs	Skipped		Oct 1, 2026 8:08pm UTC

[greptile-apps]

Confidence Score: 5/5

[Medium risk] Removes workspace ID from resource tab metadata.

The PR appears safe to merge; no outstanding finding or new blocking issue was identified.

Summary

The PR makes workspace-chat resources use an implicit workspace key while retaining explicit workspace addressing for organization chats. The latest revision replaces mock-call assertions in the resource-scope test with assertions on emitted events.

• Agent CLI effects, open_resource, and tool side effects now follow the chat-owner distinction.
• No new actionable issue was identified in the changes since the previous review.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Tool[Resource-producing tool] --> Owner{Chat owner}
  Owner -->|Organization| Scoped[Resource with target workspaceId]
  Owner -->|Workspace| Implicit[Resource without workspaceId]
  Scoped --> Effects[Persist and emit resource]
  Implicit --> Effects

Loading

_{Reviews (3) · Last reviewed commit: "fix(mothership): assert emitted resource..."}

[cubic-dev-ai]

No issues found across 7 files

Confidence score: 5/5

• Automated review surfaced no issues in the provided summaries.
• No files require special attention.

_{Re-trigger cubic}

[waleedlatif1]

@greptile

[waleedlatif1]

@cubic-dev-ai review this PR

[cubic-dev-ai]

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

[cubic-dev-ai]

No issues found across 9 files

Confidence score: 5/5

• Automated review surfaced no issues in the provided summaries.
• No files require special attention.

_{Re-trigger cubic}

[waleedlatif1]

@greptile

[waleedlatif1]

@cubic-dev-ai review this PR

[cubic-dev-ai]

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

[cubic-dev-ai]

No issues found across 9 files

Confidence score: 5/5

• Automated review surfaced no issues in the provided summaries.
• No files require special attention.

_{Re-trigger cubic}