Skip to content

fix(chat): preserve per-chat resource panel widths - #8531

Merged
waleedlatif1 merged 3 commits into
stagingfrom
codex/settings-panel-size-investigation
Oct 1, 2026
Merged

waleedlatif1 merged 3 commits into
stagingfrom
codex/settings-panel-size-investigation

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Oct 1, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Remember resource/chat split widths per user and chat in workspace and organization views. Restore them after settings navigation, reload, and collapse/expand without erasing the preferred width when space is constrained.
  • Keep dragging imperative and persist only completed pointer or keyboard adjustments. Preserve preferences during pending-chat adoption and lazy panel hydration, with bounded local history. Cancel interrupted drags, restore native browser alignment immediately, and reapply current layout bounds when a gesture ends. Keep active drags and native bounds messages on the assigned chat during pending-ID adoption.
  • Return from settings to the original chat, resource, and view by preserving the complete URL across supported settings entry points.

Type of Change

  • Bug fix

Testing

  • 93 tests passed across the affected chat, settings navigation, and preference-store suites.
  • Electron shared-panel lifecycle regression passed, including real native-browser alignment and chat-ID handoff checks; JSON checks and timings are written to CHAT_PANEL_REPORT_PATH or the Playwright output directory and uploaded on CI failure.
  • Confirmed the original remount reset, URL query loss, late pending-chat writes, pre-hydration overwrite, interrupted drag, mid-drag viewport clamp, native alignment, and in-flight chat adoption regressions fail without their fixes.
  • App and desktop type checks, cleanup review, lint, block registry check, all 54 repository audits, committed artifact regeneration, and docs manifest check passed.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Oct 1, 2026 7:20pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium risk] Adds chat panel width persistence across navigation and chat switches.

The PR appears safe to merge, with non-blocking dashboard usability and unnecessary-query concerns.

Summary

The PR preserves per-user, per-chat resource-panel widths across navigation and chat-ID adoption, restores full settings return URLs, and adds Electron regression coverage. Changes since the previous review also add live dashboard fences and chart annotations, refactor dashboard time and query handling, and scope account OAuth outbound requests to their authorized organization.

  • The earlier drag findings are resolved; two non-blocking concerns remain in the new dashboard embed behavior.
Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Chat[Workspace or organization chat] --> Resize[Resource-panel resize hook]
  Resize --> Preferences[Per-user, per-chat width store]
  Resize --> Native[Scoped native browser bounds]
  Settings[Settings entry] --> Return[Saved full return URL]
  Return --> Chat
  Markdown[Dashboard code fence] --> Embed[Dashboard embed]
  Embed --> Panels[Analytics panels and charts]
Loading

Reviews (3) · Last reviewed commit: "fix(chat): keep active resizes aligned a..."

Comment thread apps/sim/app/workspace/[workspaceId]/home/hooks/use-mothership-resize.ts Outdated
Comment thread apps/sim/app/workspace/[workspaceId]/home/hooks/use-mothership-resize.ts Outdated

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 21 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread apps/sim/app/workspace/[workspaceId]/home/hooks/use-chat.ts
Comment thread .github/workflows/desktop-e2e.yml
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 21 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread .github/workflows/desktop-e2e.yml
@waleedlatif1
waleedlatif1 force-pushed the codex/settings-panel-size-investigation branch from 77afdbc to 8c3b0be Compare October 1, 2026 19:17
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 22 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 9a2b64d into staging Oct 1, 2026
26 of 27 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/settings-panel-size-investigation branch October 1, 2026 19:26

This branch was successfully deployed

1 active deployment
Preview — 8c3b0be5 Deployed Oct 1, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant