Skip to content

feat(oracle-fusion): add shared integration foundation - #7427

Merged
waleedlatif1 merged 1 commit into
stagingfrom
feat/oracle-fusion-foundation
Oct 8, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
feat/oracle-fusion-foundation

Conversation

@BillLeoutsakosvl346

@BillLeoutsakosvl346 BillLeoutsakosvl346 commented Sep 3, 2026 •

Copy link
Copy Markdown
Contributor

Adds the shared Oracle Fusion integration-user credential and transport used by 11 product PRs. Basic authentication is bound to an Oracle-assigned origin, with fixed-version HCM/FSCM/CRM addressing, exact identifiers, bounded JSON requests and responses, collection parsing, DNS-pinned transport, cancellation, and limited GET retries. Product blocks, tools, selectors, and response schemas remain child-owned.

Fusion uses the same connection/reconnect modal and encrypted credential lifecycle as Vanta and Ramp. Its canonical family registration supplies the Oracle name/icon and provider mapping. Password bytes are preserved through the dialog, internal/v2 create and reconnect contracts, storage, and Basic authentication; other providers keep their existing normalization. Setup copy states that Oracle authenticates on the first product request. No shared Oracle OAuth app or deployment secret is required.

Validation:

  • Repeated validate-integration against Oracle's official documentation, covering credential/model boundaries, destination restrictions, memory bounds, cancellation, and modal wiring.
  • 611 focused tests pass, plus the credential-display suite after removing one declaration-only registry-inventory assertion under test-audit. Behavioral coverage/predicate tests remain.
  • The combined OCI/Fusion/EPM checkout passes all 1,347 focused tests, including Vanta/Ramp credential regressions.
  • Root lint, all 26 workspace type-checks, all 58 audits, generated deployment configuration, docs manifest, and block-registry checks pass.
  • Password and DNS-cancellation regressions were demonstrated red before their fixes.
  • Full CI passed on 27ad726, including build, unit, HTTP/desktop E2E and database integration jobs. One unchanged billing concurrency test passed on a failed-job retry. The final rebase onto the squashed OCI foundation changed history only; its source tree is identical.

Live Fusion testing is pending a Fusion tenant and integration-user credentials; no live-account pass is claimed. Product connection buttons appear when their visible child blocks ship. Restack and independently validate all 11 product PRs, and enforce credential-provider binding in shared ordinary token resolution before shipping the first consuming product.

@vercel

vercel Bot commented Sep 3, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Oct 8, 2026 3:48pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 3, 2026 •

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR adds a product-neutral Oracle Fusion credential and transport foundation without registering product-facing services.

  • Registers a canonical Oracle Fusion integration-user credential backed by locally derived Basic authentication.
  • Adds fixed HCM, FSCM, and CRM resource addressing with constrained paths, identifiers, request bodies, methods, headers, and media types.
  • Adds DNS-pinned requests, bounded responses, attempt deadlines, limited GET retries, stable provider errors, and collection parsing utilities.

Confidence Score: 5/5

The PR appears safe to merge because no blocking failure remains in the eligible follow-up scope.

No blocking failure remains.

Important Files Changed

Filename Overview
apps/sim/lib/credentials/client-credential-accounts/descriptors.ts Adds the Oracle Fusion provider descriptor and strict canonical application-origin normalization.
apps/sim/lib/credentials/client-credential-accounts/minters/oracle-fusion.ts Validates integration-user fields and derives bounded, locally cached Basic authentication material.
apps/sim/lib/internal/oracle-fusion/client.ts Adds the DNS-pinned, deadline-aware Oracle request boundary with constrained methods, headers, retries, and response handling.
apps/sim/lib/internal/oracle-fusion/paths.ts Defines fixed-version family roots and validates family-relative resource paths.
apps/sim/lib/internal/oracle-fusion/protocol.ts Adds bounded collection parsing, self-link validation, opaque-key handling, and pagination metadata.
apps/sim/lib/internal/oracle-fusion/request-body.ts Adds bounded plain-JSON serialization with exact integer token support.

Sequence Diagram

sequenceDiagram
  participant Caller
  participant Credential as Credential Resolver
  participant Client as Oracle Fusion Client
  participant DNS as DNS Validation
  participant Oracle as Oracle Fusion
  Caller->>Credential: Resolve integration-user credential
  Credential-->>Caller: Canonical origin and Basic material
  Caller->>Client: Bounded family-relative request
  Client->>DNS: Validate origin and pin public IP
  DNS-->>Client: Validated address
  Client->>Oracle: Fixed-root request with constrained method and headers
  Oracle-->>Client: Bounded JSON or empty response
  alt Transient GET and deadline permits
    Client->>Oracle: Retry once
    Oracle-->>Client: Final response
  end
  Client-->>Caller: Parsed result or fixed error
Loading

Reviews (14): Last reviewed commit: "feat(oracle-fusion): serialize exact int..." | Re-trigger Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 18 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread apps/sim/lib/internal/oracle-fusion/client.ts Outdated
Comment thread apps/sim/lib/credentials/client-credential-accounts/descriptors.ts
@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 18 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread apps/sim/lib/internal/oracle-fusion/client.ts Outdated
@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 18 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread apps/sim/lib/internal/oracle-fusion/client.ts Outdated
@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 18 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 29 files

You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Re-trigger cubic

Comment thread apps/sim/lib/internal/oracle-fusion/client.ts
Comment thread apps/sim/lib/internal/oracle-fusion/paths.ts
Comment thread apps/sim/lib/internal/oracle-fusion/identifiers.ts Outdated
Comment thread apps/sim/lib/internal/oracle-fusion/request-body.ts Outdated
Comment thread apps/sim/lib/internal/oracle-fusion/protocol.ts Outdated
@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 19 files

Heads up: you’re close to your flex budget. Increase your flex budget so reviews don’t pause.

You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Fix all with cubic | Re-trigger cubic

Comment thread apps/sim/lib/internal/oracle-fusion/request-body.test.ts
@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 19 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Heads up: you’re close to your flex budget. Increase your flex budget so reviews don’t pause.

You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Re-trigger cubic

@waleedlatif1
waleedlatif1 force-pushed the feat/oracle-fusion-foundation branch from 6bc1422 to 830a5ad Compare October 8, 2026 05:02
@waleedlatif1
waleedlatif1 force-pushed the feat/oracle-fusion-foundation branch from 830a5ad to 590fa80 Compare October 8, 2026 15:13
@waleedlatif1
waleedlatif1 force-pushed the feat/oracle-fusion-foundation branch from 590fa80 to 27ad726 Compare October 8, 2026 15:21
@waleedlatif1
waleedlatif1 force-pushed the feat/oracle-fusion-foundation branch from 27ad726 to 2d4c963 Compare October 8, 2026 15:42
@waleedlatif1
waleedlatif1 merged commit 50ed85c into staging Oct 8, 2026
35 of 36 checks passed
@waleedlatif1
waleedlatif1 deleted the feat/oracle-fusion-foundation branch October 8, 2026 18:42

This branch was successfully deployed

1 active deployment
Preview — 2d4c9630 Deployed Oct 8, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants