Skip to content

NCD archive fixes - #162

Open
Teque5 wants to merge 1 commit into
mainfrom
feature/ncd-archive
Open

Teque5 wants to merge 1 commit into
mainfrom
feature/ncd-archive

Conversation

@Teque5

@Teque5 Teque5 commented Sep 27, 2026 •

Copy link
Copy Markdown
Collaborator

main change

  • When creating an NCD archive, the NCD file is included within the archive. There will be no sigmf-data, but the NCD will be the recording. This complies with the spec.

other related stuff

  • Archiving a metadata-only file now raises
  • Fixed bugs related to header/trailing byte offsets within NCD files
  • Raises when header/trailing bytes exceed the dataset size
  • Fixed capture byte boundary tests that silently passed due to typo
  • Refactored capture tests into test_capture.py
  • Moved shared test data into conftest.py

related issues & notes

* When creating an NCD archive, the NCD file is included within the archive.
  There will be no sigmf-data, but the NCD will be the recording.
* Archiving a metadata-only file now raises
* Fixed bugs related to header/trailing byte offsets within NCD files
* Raises when header/trailing bytes exceed the dataset size
* Fixed capture byte boundary tests that silently passed due to typo
* Refactored capture tests into `test_capture.py`
* Moved shared test data into `conftest.py`
* increment to v1.14.0
@Teque5
Teque5 requested a review from 777arc September 27, 2026 15:07
@Teque5 Teque5 self-assigned this Sep 27, 2026
@Teque5 Teque5 added bug Something isn't working enhancement New feature or request labels Sep 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bad Behavior when writing NCD to SigMF Archive

1 participant