tests: check that open_pcap returns only the captured bytes - #5216
Open
KernelClint wants to merge 1 commit into
Open
KernelClint wants to merge 1 commit into
KernelClint wants to merge 1 commit into
Conversation
The GHSA-c547 test checks the header lengths but not the data that next() returns, so it still passed with the fix reverted. AI-Assisted: yes
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5216 +/- ##
==========================================
- Coverage 81.14% 80.83% -0.31%
==========================================
Files 393 393
Lines 98325 98325
==========================================
- Hits 79786 79485 -301
- Misses 18539 18840 +301 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The GHSA-c547 test checks the header lengths but not the bytes
next()returns, so it still passes if that fix is reverted. This adds the check. Tested on macOS and Linux: passes on master, fails with the fix reverted.