Repository navigation
send_keys: skip click if Node has focus - #327
Open
seanpdoyle wants to merge 1 commit into
Open
seanpdoyle wants to merge 1 commit into
seanpdoyle wants to merge 1 commit into
Conversation
The current `Capybara::Cuprite::Page#send_keys` implementation attempts to trigger a `click` on the specified `node` argument. This commit aims to avoid that click if the element already has focus. For example, if _no_ element has focus, it is possible for the `document.body` element to serve as the focus fallback. After this change, a bare `send_keys` will not attempt to click on the `document.body` element, but will still trigger the keystrokes.
seanpdoyle
force-pushed
the
send-keys-active-element
branch
from
September 11, 2026 15:11
2253643 to
dce6322
Compare
seanpdoyle
commented
Oct 7, 2026
|
|
||
| def send_keys(node, keys) | ||
| unless evaluate_on(node: node, expression: %(_cuprite.containsSelection(this))) | ||
| unless evaluate_on(node: node, expression: %(_cuprite.containsSelection(this) || _cuprite.hasFocus(this))) |
Contributor
Author
There was a problem hiding this comment.
@route are you able to provide review for this change?
I'm happy to explore something more ad hoc if introducing a "public" hasFocus JavaScript method is undesirable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current
Capybara::Cuprite::Page#send_keysimplementation attempts to trigger aclickon the specifiednodeargument.This commit aims to avoid that click if the element already has focus. For example, if no element has focus, it is possible for the
document.bodyelement to serve as the focus fallback.After this change, a bare
send_keyswill not attempt to click on thedocument.bodyelement, but will still trigger the keystrokes.