Conversation
After rsocket#1085, RSocketRequester.dispose() only sent a connection error frame without terminating the requester or closing the duplex connection on transports where sendErrorAndClose does not complete onClose. Align dispose with the keep-alive shutdown path and add a regression test. Fixes rsocket#1126
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RSocketRequester.dispose()after the regression introduced in ensuresonCloseawaits all underlying components to be closed #1085.tryTerminateAndCloseConnectionshared with the keep-alive timeout path so dispose sets termination state and closes the duplex connection (not only sends a connection error frame).RSocketRequesterDisposeTestwith a Netty-like connection wheresendErrorAndClosedoes not completeonClose.Fixes #1126
Motivation
On Netty transports,
sendErrorAndCloseenqueues a final error frame but does not dispose the connection. After #1085,dispose()relied on that alone, sotryShutdown/terminatenever ran,onClosedid not complete, and the sender could keep emitting frames.Test plan
./gradlew :rsocket-core:test --tests io.rsocket.core.RSocketRequesterDisposeTest(JBR 17)./gradlew :rsocket-core:test --tests io.rsocket.core.RSocketRequesterTerminationTest(JBR 17)