Skip to content

Remove unused pat_record_label from the current AST - #8684

Merged
cknitt merged 2 commits into
codex/remove-unused-ppat-openfrom
codex/remove-unused-pat-record-label
Sep 28, 2026
Merged

cknitt merged 2 commits into
codex/remove-unused-ppat-openfrom
codex/remove-unused-pat-record-label

Conversation

@cknitt

@cknitt cknitt commented Sep 27, 2026

Copy link
Copy Markdown
Member

Summary

Remove the unused pat_record_label type alias from the current parsetree. It has no references in the repository, and its removal does not change the runtime AST layout or the frozen v0 PPX wire.

This is part of the parsetree v1 cleanup in #8624.

Tests

  • make test

@cknitt
cknitt added this pull request to stack #8683 September 27, 2026 08:15
@cknitt
cknitt marked this pull request as ready for review September 27, 2026 08:16

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b03a335aaf

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread CHANGELOG.md
@pkg-pr-new

pkg-pr-new Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript@8684

@rescript/belt

npm i https://pkg.pr.new/@rescript/belt@8684

@rescript/darwin-arm64

npm i https://pkg.pr.new/@rescript/darwin-arm64@8684

@rescript/darwin-x64

npm i https://pkg.pr.new/@rescript/darwin-x64@8684

@rescript/linux-arm64

npm i https://pkg.pr.new/@rescript/linux-arm64@8684

@rescript/linux-x64

npm i https://pkg.pr.new/@rescript/linux-x64@8684

@rescript/runtime

npm i https://pkg.pr.new/@rescript/runtime@8684

@rescript/win32-x64

npm i https://pkg.pr.new/@rescript/win32-x64@8684

commit: 9021982

Signed-off-by: Christoph Knittel <ck@cca.io>
Signed-off-by: Christoph Knittel <ck@cca.io>
@cknitt
cknitt merged commit 39a8ed6 into master Sep 28, 2026
24 checks passed
@cknitt
cknitt deleted the codex/remove-unused-pat-record-label branch September 28, 2026 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants