fix(compose): drop the group root so the child pages resolve - #104
Merged
Merged
Conversation
#103 fixed the MDX parse error and the children still served the section landing page. Two variables had changed together, so the brace fix never got a clean test against the nav shape. Braces stay fixed; the group drops `root` for `jobs/compose/index` as its first page, which is what storage/ and automation/ use and what resolves children correctly on the live site today. `/docs/jobs/compose` still serves the overview, so no inbound link moves.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#103 fixed the MDX parse error, and the compose children still served the section landing page nine minutes after a successful deploy. Two variables had changed together, so the brace fix never got a clean test against the nav shape.
This is the decisive one: braces stay fixed, and the group drops
rootforjobs/compose/indexas its first page. That is exactly whatstorage/andautomation/use, and both resolve their children correctly on the live site today, so it is the shape with evidence behind it rather than another guess./docs/jobs/composestill serves the overview, so no inbound link moves: the ten changelog entries, the redirects and the apex all keep working.Cost, stated plainly:
rootwas what made clicking the Compose parent open the overview and hold a child's highlight. Compose goes back to behaving like Storage and Automation there. Working pages beat a nav nicety, and any future attempt at that behaviour has to be tested against a real Mintlify build, sincemint devrenders all of this correctly either way.