Declare lodash, and say how to try a library change in the site - #375
Merged
Merged
Conversation
From review of #374. The app imports lodash in eight files and had it only because other packages bring it in; it is declared now, at the version already installed, so nothing changes in the lockfile but the declaration. CONTRIBUTING says how to try an ngx-reactome-base change here before it is merged there: install a packed build. A symlinked build (npm link, or a folder install) resolves cytoscape from that repo's node_modules rather than this repo's fork, and the build fails on mismatched types -- tried, and so is the packed install and the return to the pinned build. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups from the review of #374.
lodash:
^4.17.23, the version already installed. The lockfile's package versions are unchanged (compared name by name); only the declaration is added.CONTRIBUTING:
npm linkand folder installs symlink the library, which then resolvescytoscapefrom ngx-reactome-base's ownnode_modulesinstead of this repo's fork, so the build fails on mismatched types. I tried that, then the packed install (the embed builds), thennpm installto return to the pinned build.🤖 Generated with Claude Code