Skip to content

internals: simplify binary search midpoint calculations #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rameel merged 1 commit into from
Oct 5, 2026
Merged

internals: simplify binary search midpoint calculations #74

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions src/Ramstack.HtmxToolkit/Collections/SmallDictionary.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,13 @@ private ref KeyValuePair<TKey, TValue> Find(TKey key)

while (lo <= hi)
{
var mi = (lo + hi) >> 1;
//
// Both lo and hi are non-negative and within [0..int.MaxValue],
// so their sum fits in uint. With unchecked addition, the unsigned
// right shift handles any int wraparound, making this equivalent to
// (int)(((uint)lo + (uint)hi) >> 1), but cleaner and easier to read.
//
var mi = (lo + hi) >>> 1;
if ((uint)mi >= (uint)array.Length)
break;

Expand Down Expand Up @@ -424,7 +430,13 @@ private int IndexOf(TKey key)

while (lo <= hi)
{
var mi = lo + (hi - lo >>> 1);
//
// Both lo and hi are non-negative and within [0..int.MaxValue],
// so their sum fits in uint. With unchecked addition, the unsigned
// right shift handles any int wraparound, making this equivalent to
// (int)(((uint)lo + (uint)hi) >> 1), but cleaner and easier to read.
//
var mi = (lo + hi) >>> 1;
if ((uint)mi >= (uint)array.Length)
break;

Expand Down
Loading