Skip to content

Fix _PyOS_GetOpt() error message for non-ASCII characters #158626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 1 commit into from
Oct 3, 2026
Merged

Fix _PyOS_GetOpt() error message for non-ASCII characters #158626

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Lib/test/test_cmd_line.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -684,7 +684,7 @@ def test_del___main__(self):

@support.cpython_only
def test_unknown_options(self):
# Test unknown option -a
# Test unknown option
for option in ('-z', '--long-option', '---'):
with self.subTest(option=option):
rc, out, err = assert_python_failure('-E', option)
Expand Down
4 changes: 2 additions & 2 deletions Python/getopt.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ _PyOS_GetOpt(struct _PyOS_GetOpt *getopt)
wchar_t *ptr = wcschr(SHORT_OPTS, option);
if (ptr == NULL) {
if (error) {
fprintf(stderr, "Unknown option: -%c\n", (char)option);
fprintf(stderr, "Unknown option: -%lc\n", option);
}
return '_';
}
Expand All @@ -174,7 +174,7 @@ _PyOS_GetOpt(struct _PyOS_GetOpt *getopt)
if (getopt->index >= argc) {
if (error) {
fprintf(stderr,
"Argument expected for the -%c option\n", (char)option);
"Argument expected for the -%lc option\n", option);
}
return '_';
}
Expand Down
Loading