Run a job that the test suite with MSan to the CI - #158625
Open
StanFromIreland wants to merge 2 commits into
Open
StanFromIreland wants to merge 2 commits into
StanFromIreland wants to merge 2 commits into
Conversation
StanFromIreland
added
skip issue
skip news
infra
Member
Author
|
Note, |
StanFromIreland
marked this pull request as ready for review
October 2, 2026 21:11
StanFromIreland
requested review from
AA-Turner,
JacobCoffee,
ezio-melotti,
gpshead,
hugovk,
itamaro,
pablogsal and
webknjaz
as code owners
October 2, 2026 21:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have to disable extension modules that link against system libraries (which are not built with MSan) since memory those libraries initialise is reported as uninitialised. While this does significantly reduce coverage of some modules, it saves a great amount of CI time. I also had to unpoison a few buffers filled by libc that MSan does not intercept.
A little fix is included,
allocate_instrumentation_data()now zeroes thetool_versionsof a_PyCoMonitoringData, whichupdate_instrumentation_data()previously read uninitialised. This doesn't have an affect in practice, as the garbage data only decides whether to clear some bits that are already zero, so the outcome is the same either way.Inspired by #158584.