Repository navigation
Conversation
AI assistance was used to prepare the implementation and regression tests.
FanWu-ai
marked this pull request as ready for review
October 8, 2026 22:26
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DateandDateTimeweekday modifiers use Monday-based weekday constants to indexcalendar.monthcalendar(). That function follows the standard library's process-wide first-weekday setting, so changing the calendar display layout also changes which dates Pendulum selects:Use a separate Monday-based
Calendarinstance for the four month-calendar lookups. This fixesfirst_of,last_of, and the first occurrence innth_offor month, quarter, and year units. The caller's global calendar setting is never changed. No API or dependency changes.Tests
Validation
Linux, CPython 3.12.14:
typing_extensions: same passing results.git diff --checkpass. Built Python source files were verified against the checkout.The existing skips cover Windows-specific local-timezone behavior and two upstream timezone-rule tests. The documentation build retains six pre-existing info-level link diagnostics; source-distribution generation retains upstream Cargo metadata diagnostics. Other interpreters, operating systems, and hosted CI are not claimed as tested locally.
AI assistance was used to prepare the implementation and regression tests.