Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scientific formatting normalizes the mantissa before rounding, so rounding across a power of ten can add an extra leading digit without updating the exponent. For example,
format_scientific(Decimal("9.99"), "0.0E0", locale="en_US")currently produces10.0E0; it should produce1.0E1with the pattern's two significant digits.Normalize a finite mantissa that gains a leading digit during rounding, adjusting the exponent and its localized sign. The regressions cover positive/negative exponents, crossing zero with explicit exponent signs, exponent padding, multiple mandatory leading digits, negative numbers, Arabic numbering symbols, and preservation of non-carry, zero, infinity, and disabled quantization behavior.
The expected formatting follows the LDML scientific notation rules for integer digits and maximum significant digits. Related open PR #1281 changes initial exponent grouping; this fix addresses rounding carry with Babel's current normalization. PR #1286 addresses directional rounding of negative values, which is a separate issue.
Validation:
This contribution was prepared with OpenAI Codex assistance and independently reviewed before submission.