remove zend_atomic abstraction - #23927
Merged
Merged
Conversation
henderkes
marked this pull request as draft
September 26, 2026 17:03
Girgias
reviewed
Sep 26, 2026
Contributor
Author
|
Question here is if it's even worth carrying zend_atomic_,,, functions anymore, or if we might as well just call e.g. |
henderkes
force-pushed
the
cleanup/zend_atomic
branch
from
September 27, 2026 08:28
da9b019 to
4be1214
Compare
henderkes
changed the title
henderkes
marked this pull request as ready for review
September 27, 2026 11:33
henderkes
requested review from
LamentXU123,
TimWolla,
devnexen,
dstogov and
zeriyoshi
as code owners
September 27, 2026 11:33
Member
Lately we have just removed the compatibility layers outright. If necessary folks can backport them themselves. Or they just upgrade to C11 for all PHP versions they support, which is reasonable. |
Contributor
Author
|
Yeah I already committed it. The extensions imo don't make keeping the layer worth it. For C++ mode extensions I've stubbed |
henderkes
force-pushed
the
cleanup/zend_atomic
branch
3 times, most recently
from
September 29, 2026 08:20
126c35b to
4cc95a6
Compare
henderkes
commented
Sep 29, 2026
henderkes
force-pushed
the
cleanup/zend_atomic
branch
from
September 29, 2026 10:02
36aca29 to
2050d79
Compare
Contributor
Author
|
@shivammathur @TimWolla rebased to only remove the atomic macro layer. |
shivammathur
approved these changes
Sep 29, 2026
TimWolla
reviewed
Sep 29, 2026
TimWolla
requested review from
arnaud-lb
and removed request for
LamentXU123
September 29, 2026 10:28
TimWolla
approved these changes
Sep 29, 2026
arnaud-lb
approved these changes
Sep 29, 2026
Member
|
Nice! |
bukka
added a commit
to bukka/php-src
that referenced
this pull request
Sep 29, 2026
* upstream/master: (99 commits) NEWS Fix property hook escape analysis causing misoptimization Fix __isset escape analysis causing misoptimization Fix memory leak when closing a statement on a killed connection Reset field_count for OK packet (php#23890) Fix phpGH-23986: Clear the realpath cache in the child after pcntl_fork() (php#23987) ext/standard: Remove redundant if-branch in rot13 (php#23795) ext/pdo: Throw a ValueError from bindColumn() for an unknown column (php#23835) Zend: rename zend_object* parameter to "this_ptr" for zend_call_* functions (php#23989) ext/pdo: Release driver options after bindParam and bindColumn tests: Raise test stack for stream error depth limit under MSan (php#23985) Zend: Remove zend_atomic.[ch] abstraction (php#23927) fibers: fix phpGH-23921 (Fibers start with error_reporting = 0 when the error_reporting INI directive is not set) ext/pdo: Keep statement class when ATTR_STATEMENT_CLASS is rejected Verify bundled sources using CI - Opcache JIT IR (php#20179) zend_portability: Simplify definition of `ZEND_NORETURN` (php#23908) Fix phpGH-23758: PDO_Firebird returns null for empty BLOBs (php#23763) Remove redundant parentheses in session tests (php#23609) Update IR (php#23861) Fix OSS-Fuzz #552682112: assertion failure wrt zp_arg_must_be_sent_by_ref() (php#23760) ... # Conflicts: # ext/openssl/xp_ssl.c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use C11 atomics directly.