Fix stream_select() failing unpredictably (and crashing on Windows) with many descriptors - #14452

Open

frodeborli wants to merge 30 commits into

frodeborli:stream_select_unlimited

Commits on Jun 3, 2024

Updated the stream_select() function so that it supports bigger file descriptor numbers without recompiling PHP on non-Windows OS, by passing the select() system call dynamically generated fd_sets …
frodeborli
committed
b570514
Removed unused functions. Unsure if this is correct, since I don't know if those functions could be referenced by other extensions.
frodeborli
committed
166a0e4
Merge branch 'php:master' into stream_select_unlimited
frodeborli
authored
e3edadb
Fix bug which was found by CI on php-src when commiting using a different architecture than what I developed this on.
frodeborli
committed
f8c53e5
Fixed mistake from lazyness. The function now properly finds the largest file descriptor id and allocates a correct size.
frodeborli
committed
5631e3b
Apparently the CI on github finds stuff my building process does not find.
frodeborli
committed
581a8d5

Commits on Jun 4, 2024

Problems
frodeborli
committed
b93d754
Updated code setting the max_fds based on the ulimit for the process.
frodeborli
committed
ae8d2ec

Commits on Jun 5, 2024

Commits on Jun 7, 2024

Refactored code and improved safey of macros according to comments on the PR from github.
frodeborli
committed
7c07b77

Commits on Jun 25, 2024

Commits on Jul 1, 2024

Commits on Jul 2, 2024

Merge branch 'php:master' into stream_select_unlimited
frodeborli
authored
8a15aa3
fix: Improvments suggested by @arnaud-lb
frodeborli
committed
be6d295

Commits on Sep 22, 2026

fix: keep Windows on native fd_set, fix indentation to match .editorconfig

frodeborli
and
claude
committed
30aff57
Merge upstream php-src master into stream_select_unlimited

frodeborli
and
claude
committed
a97210c
fix: two heap-safety bugs in fd_bigset found by code review

frodeborli
and
claude
committed
9df943c
Update GH-9590 tests: fixing the fd_bigset limitation, not papering over it

frodeborli
and
claude
committed
d2b1dec
Windows: grow stream_select() fd_set on demand and cap handle count
frodeborli
committed
9398932
Document the POSIX fd_set limit removal; correct UPGRADING and test wording
frodeborli
committed
2fa18f0
Merge remote-tracking branch 'upstream/master' into stream_select_unlimited
frodeborli
committed
a7ddad0

Commits on Sep 25, 2026

Commits on Sep 26, 2026

Merge remote-tracking branch 'upstream/master' into stream_select_unlimited
frodeborli
committed
acecffe

Commits on Sep 29, 2026