Skip to content

fix(operators)!: throw QueryKitParsingException for an unknown logical operator #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pdevito3 merged 1 commit into from
Oct 2, 2026
Merged

fix(operators)!: throw QueryKitParsingException for an unknown logical operator #164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions QueryKit.UnitTests/FilterParsingRegressionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,6 +342,14 @@ public void whitespace_around_a_group_gives_the_same_filter(string input, string
result.Should().Equal(expectedResult);
}

[Fact]
public void unknown_logical_operator_throws_query_kit_parsing_exception()
{
var act = () => LogicalOperator.GetByOperatorString("xor");

act.Should().Throw<QueryKitParsingException>().WithMessage("Operator xor is not supported");
}

private static TResult WithCulture<TResult>(string cultureName, Func<TResult> action)
{
var originalCulture = CultureInfo.CurrentCulture;
Expand Down
3 changes: 2 additions & 1 deletion QueryKit/Operators/LogicalOperator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ namespace QueryKit.Operators;
using System.Linq.Expressions;
using Ardalis.SmartEnum;
using Configuration;
using Exceptions;

public abstract class LogicalOperator : SmartEnum<LogicalOperator>
{
Expand All @@ -15,7 +16,7 @@ public static LogicalOperator GetByOperatorString(string op)
var logicalOperator = List.FirstOrDefault(x => x.Operator() == op);
if (logicalOperator == null)
{
throw new Exception($"Operator {op} is not supported");
throw new QueryKitParsingException($"Operator {op} is not supported");
}
return logicalOperator;
}
Expand Down
Loading