Feat: "Add to Home screen" option to create folder shortcuts with deep link by Lightz2002 · Pull Request #219 · opencloud-eu/android

Lightz2002 · 2026-08-21T15:06:11Z

Adds an "Add to Home screen" action for folders that pins a launcher shortcut,
deep-linking straight into that folder when tapped.

Changes

Add ADD_TO_HOME_SCREEN to FileMenuOption and wire it into the file actions menu
(action_add_to_home) with a new icon; only shown for single-selected folders via
FilterFileMenuOptionsUseCase
New AddToHomeScreenDialogFragment: pre-filled, editable shortcut name with validation
(empty name, max filename length, forbidden characters)
New FolderShortcutHelper: creates a pinned shortcut via ShortcutManager (API 26+),
embedding the folder's remote ID, remote path, and space ID in the intent
FileDisplayActivity handles the new OPEN_SHORTCUT action: resolves the folder by
remote path + space ID from local storage and navigates directly into it; extras are
consumed after handling; shows an error snackbar if the folder no longer exists locally

Notes

Devices below API 26 show a toast instead of creating a shortcut
Shortcut opens in All Files view regardless of the last used file list option

Testing

Long-press/overflow menu on a folder → "Add to Home screen" → confirm → pin the shortcut
Tap the shortcut → app opens directly inside the target folder
Rename the shortcut in the dialog; verify empty names / forbidden chars are rejected
Delete the folder, then tap the shortcut → error message shown

guruz · 2026-08-31T14:42:10Z

@wernrab can you review this one?

@Lightz2002 I think "add folder path to home screen" is a not so good commit message.

Copilot

🟡 Changes recommended

There are user-visible correctness issues (misleading success messaging and incomplete/unsafe validation + a potential pre-contentView snackbar crash path) that should be fixed before approval.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Adds an “Add to Home screen” action for folder items, allowing users to pin a launcher shortcut that deep-links back into the selected folder, with UI for naming/validating the shortcut and runtime handling to open the target folder.

Changes:

Introduces a new FileMenuOption.ADD_TO_HOME_SCREEN and wires it into the file actions menu (icon + string resources).
Adds AddToHomeScreenDialogFragment to collect/validate the shortcut name and FolderShortcutHelper to request a pinned shortcut via ShortcutManager.
Extends FileDisplayActivity to process the shortcut intent and navigate into the resolved folder.

File summaries

File	Description
opencloudDomain/src/main/java/eu/opencloud/android/domain/files/model/FileMenuOption.kt	Adds a new menu option enum value for the feature.
opencloudApp/src/main/res/values/strings.xml	Adds UI strings for the new menu item and dialog.
opencloudApp/src/main/res/menu/file_actions_menu.xml	Adds the new “Add to Home screen” menu item.
opencloudApp/src/main/res/drawable/ic_action_add_to_home.xml	Adds the vector icon for the new action.
opencloudApp/src/main/java/eu/opencloud/android/usecases/files/FilterFileMenuOptionsUseCase.kt	Shows the option only for single-selected folders.
opencloudApp/src/main/java/eu/opencloud/android/ui/activity/FileDisplayActivity.kt	Handles shortcut intents and navigates into the folder.
opencloudApp/src/main/java/eu/opencloud/android/presentation/files/filelist/MainFileListFragment.kt	Opens the new dialog and triggers shortcut creation.
opencloudApp/src/main/java/eu/opencloud/android/presentation/files/addtohomescreen/FolderShortcutHelper.kt	Implements pinned shortcut creation and intent extras.
opencloudApp/src/main/java/eu/opencloud/android/presentation/files/addtohomescreen/AddToHomeScreenDialogFragment.kt	Adds the shortcut naming dialog with validation.
opencloudApp/src/main/java/eu/opencloud/android/extensions/FileMenuOptionExt.kt	Maps the new option to menu id/string/icon resources.

Review details

Suppressed comments (1)

opencloudApp/src/main/java/eu/opencloud/android/presentation/files/addtohomescreen/FolderShortcutHelper.kt:36

requestPinShortcut() can fail/return false; also when pinning isn’t supported the code currently shows the same “added” success toast. This can report success even when the launcher declined/doesn’t support pinning.

        if (shortcutManager?.isRequestPinShortcutSupported != true) {
            Toast.makeText(context, context.getString(R.string.add_to_home_screen_shortcut_added), Toast.LENGTH_SHORT).show()
            return
        }

Files reviewed: 10/10 changed files
Comments generated: 3
Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Lightz2002 · 2026-09-05T03:45:13Z

Hi @guruz , Please kindly inform me if there are changes i need to make since the pr is failing, thanks

guruz · 2026-09-05T08:32:41Z

Hey @Lightz2002 ! You can run detekt also on your local machine with ./gradlew build, it should run detekt for you.
See detekt output here: https://github.com/opencloud-eu/android/actions/runs/33406305453/job/100174046056?pr=219

@wernrab We should really change this maximum function length from 100 to 200 or whatever :(

guruz · 2026-09-10T11:44:24Z

@wernrab We should really change this maximum function length from 100 to 200 or whatever :(

-> #225

Lightz2002 · 2026-09-14T15:39:12Z

hi @guruz @wernrab , i have commited again to pass the detekt last time. can you help check and review again, thanks.

Copilot

🟡 Changes recommended

One or more issues must be addressed before approval.

Get a fresh assessment by requesting another Copilot review.

Review details

Suppressed comments (3)

opencloudApp/src/main/java/eu/opencloud/android/presentation/files/addtohomescreen/FolderShortcutHelper.kt:52

The dialog allows names up to the filesystem limit (223 characters), but Android pinned shortcuts impose much smaller limits on shortLabel/longLabel. A valid 26+ character input can therefore fail during ShortcutInfo validation or pinning instead of creating the shortcut. Validate against the shortcut API limits or deliberately truncate before building it.

        val shortcut = ShortcutInfo.Builder(context, shortcutId)
            .setShortLabel(shortcutName)
            .setLongLabel(shortcutName)

opencloudApp/src/main/java/eu/opencloud/android/presentation/files/addtohomescreen/FolderShortcutHelper.kt:27

On API levels below 26 this branch cannot create a pinned shortcut, but it displays the success message Shortcut added to Home screen. Users are therefore told the action succeeded even though no shortcut was created; use an unsupported-version message or hide/disable the action.

            Toast.makeText(context, context.getString(R.string.add_to_home_screen_shortcut_added), Toast.LENGTH_SHORT).show()

opencloudApp/src/main/java/eu/opencloud/android/ui/activity/FileDisplayActivity.kt:1992

This error path runs from onCreate before setContentView initializes the activity layout. Consequently findViewById(R.id.list_layout) is null and Snackbar.make can fail, so tapping a shortcut for a deleted folder crashes instead of showing the documented error. Defer the snackbar until after the content view is set.

                showMessageInSnackbar(R.id.list_layout, getString(R.string.default_error_msg))

Files reviewed: 10/10 changed files
Comments generated: 4
Review effort level: Lite

Lightz2002 · 2026-09-18T15:26:52Z

Hi @wernrab i have made adjustments again, please kindly help check and review again, Thanks for your input !

This reverts commit be34190.

Lightz2002 · 2026-10-03T03:11:30Z

@wernrab i have made some adjustments again.

Copilot

Copilot review overview

🟡 Changes recommended

One or more issues must be addressed before approval.

Review effort: Lite
Findings: 1 · 4

Open (5)

Shortcut target activity is not exported · New
Shortcut labels exceed Android's length limits · New
This handles only the bottom-sheet path. The same action_add_to_home item is inflated into the…
requestPinShortcut is asynchronous, and passing a null result callback means this code cannot…
This shortcut intent carries only path and space, while FileDisplayActivity resolves it through…

Resolved since last review (3)

handleShortcutIntent() is called before setContentView(). If the folder can’t be resolved,…
When the launcher does not support pinned shortcuts, this branch also reports `Shortcut added to…
On API < 26, this path shows a success toast even though no shortcut is created. This is misleading…

The launcher starts shortcut intents from another UID, so the non-exported FileDisplayActivity was rejected with a SecurityException. A dedicated exported trampoline validates the shortcut action and forwards only the shortcut extras to the real activity.

The shortcut carried only path and space, so after an account switch the same path resolved against the wrong account (or not at all). Include the folder owner in the shortcut intent and restart with that account selected before looking the folder up.

The dialog accepted names up to MAX_FILENAME_LENGTH (223 chars) and passed them unchanged to setShortLabel/setLongLabel, which Android caps at 10/25 recommended characters. Validate the name in the dialog and truncate labels defensively before building the ShortcutInfo.

requestPinShortcut is asynchronous and the success toast fired unconditionally before the user even confirmed the launcher dialog. Pass an IntentSender backed by ShortcutPinResultReceiver and report success only when the launcher actually pinned the shortcut; surface an error toast when requestPinShortcut returns false.

The action was only wired to the bottom-sheet menu; when chosen from the long-press selection action mode it fell through onSingleFileActionChosen and did nothing. Open the dialog via the child fragment manager and clear the selection like other actions.

Copilot

Copilot review overview

🟡 Changes recommended

One or more issues must be addressed before approval.

Review effort: Lite
Findings: 1 · 2

Open (3)

Shortcut target activity is not exported
Prevent fallback lookup in the wrong account · New
This shortcut intent carries only path and space, while FileDisplayActivity resolves it through…

Resolved since last review (3)

Shortcut labels exceed Android's length limits
This handles only the bottom-sheet path. The same action_add_to_home item is inflated into the…
requestPinShortcut is asynchronous, and passing a null result callback means this code cannot…

Previously missed (1)

In code that hasn't changed since last review

Handle shortcut intents in existing activity instances

opencloudApp/src/main/java/eu/opencloud/android/ui/activity/FileDisplayActivity.kt:258

handleShortcutIntent() is only invoked from onCreate, but the trampoline starts FileDisplayActivity with FLAG_ACTIVITY_CLEAR_TOP. When the app already has a FileDisplayActivity, Android delivers the shortcut intent to that existing instance via onNewIntent; BaseActivity.onNewIntent() does not call this handler, so tapping a pinned shortcut while the app is open is a no-op (and this also prevents the cross-account redirect from being processed). Handle the shortcut intent from onNewIntent as well, including updating the activity's intent/account state before resolving the folder.

+        if (shortcutRemotePath != null) {
+            val file = storageManager.getFileByPath(shortcutRemotePath, shortcutSpaceId)
+            if (file != null) {
+                shortcutFolderToNavigate = file
+            } else {
+                showMessageInSnackbar(
+                    R.id.list_layout,
+                    getString(R.string.add_to_home_screen_shortcut_folder_missing)
+                )
+            }
+        }


Copilot

Copilot review overview

🟡 Changes recommended

One or more issues must be addressed before approval.

Review effort: Lite
Findings: 2

Open (2)

Handle shortcut intents in onNewIntent · New
Prevent fallback lookup in the wrong account

Resolved since last review (2)

Shortcut target activity is not exported
This shortcut intent carries only path and space, while FileDisplayActivity resolves it through…

+    private fun handleShortcutIntent() {
+        val sc = eu.opencloud.android.presentation.files.addtohomescreen.FolderShortcutHelper
+        if (intent?.action != sc.ACTION_OPEN_SHORTCUT) return


add folder path to home screen

cd4fc3f

wernrab requested review from guruz and wernrab August 31, 2026 13:56

wernrab requested a lite review from Copilot August 31, 2026 14:49

Copilot started reviewing on behalf of wernrab August 31, 2026 14:50 View session

Copilot AI reviewed Aug 31, 2026

View reviewed changes

Add Filename Validation

dd2968d

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

ryan and others added 2 commits September 10, 2026 21:10

shorten method name

2df383d

Merge branch 'opencloud-eu:main' into main

adee8e7

This comment was marked as resolved.

Sign in to view

wernrab requested a lite review from Copilot September 17, 2026 15:53

Copilot started reviewing on behalf of wernrab September 17, 2026 15:54 View session

This comment was marked as outdated.

Sign in to view

Copilot AI reviewed Sep 17, 2026

View reviewed changes

prevent app crash after folder deleted or renamed

530696f

wernrab self-requested a review October 1, 2026 09:41

wernrab reviewed Oct 1, 2026

View reviewed changes

Comment thread ...rc/main/java/eu/opencloud/android/presentation/files/addtohomescreen/FolderShortcutHelper.kt

wernrab reviewed Oct 1, 2026

View reviewed changes

Comment thread ...rc/main/java/eu/opencloud/android/presentation/files/addtohomescreen/FolderShortcutHelper.kt

ryan and others added 4 commits October 3, 2026 09:31

fix wrong notif message handling

be34190

Revert "fix wrong notif message handling"

ba4bd66

This reverts commit be34190.

Merge branch 'opencloud-eu:main' into main

ebd2f41

invert wrong toast message

d0800fa

wernrab self-requested a review October 5, 2026 14:25

wernrab requested a lite review from Copilot October 5, 2026 14:29

Copilot started reviewing on behalf of wernrab October 5, 2026 14:29 View session

Copilot AI reviewed Oct 5, 2026

View reviewed changes

Comment thread ...rc/main/java/eu/opencloud/android/presentation/files/addtohomescreen/FolderShortcutHelper.kt

Comment thread ...rc/main/java/eu/opencloud/android/presentation/files/addtohomescreen/FolderShortcutHelper.kt

ryan added 5 commits October 6, 2026 14:39

wernrab requested a lite review from Copilot October 7, 2026 09:45

Copilot started reviewing on behalf of wernrab October 7, 2026 09:46 View session

Copilot AI reviewed Oct 7, 2026

View reviewed changes

wernrab requested a lite review from Copilot October 7, 2026 14:16

Copilot started reviewing on behalf of wernrab October 7, 2026 14:17 View session

Copilot AI reviewed Oct 7, 2026

View reviewed changes

Conversation

Lightz2002 commented Aug 21, 2026

Changes

Notes

Testing

Uh oh!

guruz commented Aug 31, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Suppressed comments (1)

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Lightz2002 commented Sep 5, 2026

Uh oh!

guruz commented Sep 5, 2026

Uh oh!

guruz commented Sep 10, 2026

Uh oh!

Lightz2002 commented Sep 14, 2026

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as outdated.

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Suppressed comments (3)

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Lightz2002 commented Sep 18, 2026

Uh oh!

Uh oh!

Uh oh!

Lightz2002 commented Oct 3, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants