Repository navigation
Add fxmacrodata module - #1284
Merged
Merged
Conversation
Contributor
Author
|
Small hardening pass: requests no longer follow redirects, so the API key is never re-sent to another host, the key is trimmed before use, and a 200 response with an error body or an unexpected shape now raises a clear error instead of a missing-column failure. (not run locally) |
Contributor
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a small
fxmacrodatamodule that wraps the FXMacroData REST API (economic indicator releases, release calendars and FX spot rates) and returns plain Nushell tables.datetimecolumns, so things likewhere release_time < ((date now) + 2wk)just work.$env.FXMACRODATA_API_KEYis set it is sent as anX-API-Keyheader (never in the URL).--rawto get the untouched JSON response.Checked with
nu-check --as-moduleon nu 0.116.1, and ran each command against the live API.