test: add benchmark test for quic - #66317
Open
soulee-dev wants to merge 1 commit into
Open
soulee-dev wants to merge 1 commit into
soulee-dev wants to merge 1 commit into
Conversation
The benchmarks under benchmark/quic were not exercised by any test, so changes to node:quic could silently break them. Add a benchmark test that runs them when QUIC is available, and trigger the QUIC workflow when the benchmarks or their test change. Signed-off-by: Soul Lee <alus20x@gmail.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
meta
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66317 +/- ##
==========================================
+ Coverage 90.37% 90.38% +0.01%
==========================================
Files 790 790
Lines 274272 274497 +225
Branches 52502 52568 +66
==========================================
+ Hits 247865 248103 +238
+ Misses 16890 16876 -14
- Partials 9517 9518 +1 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The benchmarks in
benchmark/quicwere not run by any test, so changes tonode:quiccould break them unnoticed. This adds a benchmark test for them and makes the QUIC workflow run when they change.Refs: #65522
Refs: #60122