watch: detect files replaced via unlink and create - #63888
Merged
nodejs-github-bot merged 2 commits intoSep 27, 2026
Merged
Conversation
ShogunPanda
approved these changes
Jun 13, 2026
|
When can we expect this to be merged? |
This comment was marked as outdated.
This comment was marked as outdated.
This comment has been minimized.
This comment has been minimized.
Member
|
CI is failing on not ok 5496 parallel/test-watch-mode-files_watcher
---
duration_ms: 120070.78700
severity: fail
exitcode: -15
stack: |-
timeout
... |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63888 +/- ##
==========================================
- Coverage 90.38% 90.38% -0.01%
==========================================
Files 790 790
Lines 274497 274508 +11
Branches 52557 52566 +9
==========================================
+ Hits 248100 248101 +1
- Misses 16879 16883 +4
- Partials 9518 9524 +6
🚀 New features to boost your workflow:
|
marcopiraccini
force-pushed
the
watch-monitor-replaced-files
branch
from
September 19, 2026 11:47
8b2094b to
fbf6b2d
Compare
marcopiraccini
force-pushed
the
watch-monitor-replaced-files
branch
from
September 26, 2026 03:02
fbf6b2d to
17c0d62
Compare
Contributor
Author
|
@ShogunPanda @trivikr the NOTE: |
panva
approved these changes
Sep 26, 2026
Collaborator
Signed-off-by: marcopiraccini <marco.piraccini@gmail.com>
Signed-off-by: marcopiraccini <marco.piraccini@gmail.com>
marcopiraccini
force-pushed
the
watch-monitor-replaced-files
branch
from
September 26, 2026 11:58
17c0d62 to
f8e34b1
Compare
panva
approved these changes
Sep 26, 2026
Collaborator
Collaborator
Collaborator
|
Landed in 3641c36 |
HoonDongKang
pushed a commit
to HoonDongKang/node
that referenced
this pull request
Sep 28, 2026
Signed-off-by: marcopiraccini <marco.piraccini@gmail.com> PR-URL: nodejs#63888 Fixes: nodejs#51621 Refs: nodejs#54774 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #51621
Refs: #54774
On Linux,
--watchstopped restarting after the first time a watched file was replaced via unlink+create or rename (atomic saves,docker compose watch, bind mounts), so it appeared to "only reload the first time".filterFilewatched each file directly, which binds the inotify watch to the file's inode.On replacement the old inode is unlinked: the watch fires once, then dies; the new file's inode is never watched.
Fix: on Linux, watch the parent directory non-recursively instead of the file. The directory inode is stable across replacements, and unrelated siblings are still discarded by the filter-mode check in
#onChange. macOS/Windows already watched the directory and were unaffected.Other platforms without recursive watching (AIX, SmartOS, BSDs) keep watching the file itself: a directory watch there does not report the changed entry, which made the test time out on AIX and SmartOS.