Repository navigation
chore: remove unofficial-builds dependency - #2649
Conversation
Remove query of https://unofficial-builds.nodejs.org Incorporate musl into security builds Remove update.sh security build switch Update documentation Signed-off-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
sxa
left a comment
There was a problem hiding this comment.
Part of me wants to say leave it in just in case we want it in the future but in reality that doesn't really make any sense. The less dependency that anything in the release process has on unofficial builds the better.
If we ever do need to generate images from unofficial builds in the future then we should publish them somewhere else outside the "docker official builds" process.
nschonni
left a comment
There was a problem hiding this comment.
Thanks! I think this is the parts I had tried stripping out before (and more).
I think I had one other part as part of one of the re-writes so we could execute locally, but it doesn't make sense to try to introduce that here. I'll try and rebase some of those other rewrite PRs again (but also feel free to suggest/push to those)
build-automationwaits for unusedmuslbuilds fromunofficial-builds#2646Description
muslbuild.linux-x64-muslis now sourced from https://nodejs.org/dist-s(security) option from ./update.sh which allowed updatingDockerfileinstances even if the corresponding unofficial musl build was unavailableMotivation and Context
PR #2621 updated the Dockerfile-alpine.template to pull the
linux-x64-muslbuild from the official site https://nodejs.org/dist instead of from https://unofficial-builds.nodejs.org/download/releaseThe official
linux-x64-muslbuild is immediately available together with builds for other platforms and architectures when a Node.js release has been declared promoted.Polling the unofficial site for availability of a
muslbuild is no longer relevant. It also leads to unnecessary delays.There is also no longer a need to handle security and non-security releases differently. Previously, security releases didn't wait for
muslbuild availability so that they could be expedited. Security releases can now proceed immediately with an Alpine build without any wait.Testing Details
update.sh
Execute each of the examples. Use
git restore .between each test.Confirm removed -s option is rejected:
Outputs
illegal option -- sbuild-automation.mjs
There is no offline test available for
build-automation.mjs.Checkout
6b8944cbbefore Node.js 26.11.0 was released, cherry-pick the commit from this PR and run the workflow .github/workflows/automatic-updates.yml withgit diff.Types of changes
Checklist