Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1145 +/- ##
=======================================
Coverage 92.64% 92.64%
=======================================
Files 244 244
Lines 23113 23113
Branches 2263 2263
=======================================
Hits 21412 21412
Misses 1692 1692
Partials 9 9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ovflowd
left a comment
There was a problem hiding this comment.
Maybe we should actually address the issue? Can we maybe instead of using index, use a base64 of segment?
|
Thanks for the suggestion! In this case, the list is derived from splitting a fixed string, so the segments are static and never reorder or change length — index keys are safe here. Using a base64 encoding of the segment wouldn't work well either, since segments can repeat, producing two identical segments, which would lead to duplicate keys. Suppressing the rule with an explanatory comment seemed like the clearest option. |
Description
When running
node --run lint, the following warning message will appear.Validation
Related Issues
Check List
node --run testand all tests passed.node --run format:check&node --run lint.