Skip to content

fix(react): resolve heading names that share a substring with their receiver - #1116

Open
btea wants to merge 1 commit into
nodejs:mainfrom
btea:fix/method-match-error
Open

btea wants to merge 1 commit into
nodejs:mainfrom
btea:fix/method-match-error

Conversation

@btea

@btea btea commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Description

getFullName located the entry name with indexOf, which matched the first occurrence of the name anywhere in the heading — including inside the receiver. diagnostics_channel.channel was thus truncated to diagnostics_channel, and the same bug affected sign.sign, emitter.emit, readable.read, and 8 other headings.

before after
image image

Validation

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run node --run test and all tests passed.
  • I have check code formatting with node --run format:check & node --run lint.
  • I've covered new added functionality with unit tests if necessary.

@vercel

vercel Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
api-docs-tooling Ready Ready Preview Sep 29, 2026 7:29am UTC

Request Review

@btea
btea marked this pull request as ready for review September 29, 2026 07:28
@btea
btea requested a review from a team as a code owner September 29, 2026 07:28
@codecov

codecov Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.42%. Comparing base (6c484cb) to head (53d0744).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1116      +/-   ##
==========================================
+ Coverage   91.38%   91.42%   +0.03%     
==========================================
  Files         249      249              
  Lines       23253    23347      +94     
  Branches     2244     2257      +13     
==========================================
+ Hits        21250    21344      +94     
  Misses       1994     1994              
  Partials        9        9              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

Copy link
Copy Markdown
Contributor

api-links Generator

Performance estimate (single CI run)

  • Generation time: 1.4% slower (1.42 s → 1.44 s)
  • Peak memory: 3.6% lower (440.25 MB → 424.30 MB)

json Generator

Performance estimate (single CI run)

  • Generation time: 6.2% slower (6.41 s → 6.81 s)
  • Peak memory: 1.4% lower (1.74 GB → 1.71 GB)

legacy-html Generator

Performance estimate (single CI run)

  • Generation time: 2.0% faster (42.69 s → 41.84 s)
  • Peak memory: 1.0% higher (2.34 GB → 2.37 GB)

legacy-json Generator

Performance estimate (single CI run)

  • Generation time: 4.9% slower (7.81 s → 8.19 s)
  • Peak memory: 12.8% higher (1.57 GB → 1.77 GB)

llms-txt Generator

Performance estimate (single CI run)

  • Generation time: 2.1% slower (7.61 s → 7.77 s)
  • Peak memory: 6.5% higher (1.52 GB → 1.62 GB)

orama-db Generator

Output size: 1 file changed · net +152.00 B

File size details
File Main PR Change
orama-db.json 9.54 MB 9.54 MB +152.00 B (+0.0%)

Performance estimate (single CI run)

  • Generation time: 23.3% faster (6.45 s → 4.95 s)
  • Peak memory: 7.3% higher (1.76 GB → 1.89 GB)

web Generator

Output size: 14 files changed · net +3.21 KB

File size details
File Main PR Change
all.html 32.97 MB 32.97 MB +1.60 KB (+0.0%)
webstreams.html 535.38 KB 535.70 KB +326.00 B (+0.1%)
stream.html 1.22 MB 1.22 MB +292.00 B (+0.0%)
crypto.html 1.96 MB 1.96 MB +268.00 B (+0.0%)
globals.html 281.61 KB 281.78 KB +174.00 B (+0.1%)
sqlite.html 520.05 KB 520.19 KB +150.00 B (+0.0%)
events.html 834.21 KB 834.35 KB +145.00 B (+0.0%)
diagnostics_channel.html 529.81 KB 529.93 KB +126.00 B (+0.0%)
stream_iter.html 734.29 KB 734.41 KB +124.00 B (+0.0%)
webcrypto.html 640.93 KB 640.94 KB +14.00 B (+0.0%)
dtls.html 300.38 KB 300.38 KB +8.00 B (+0.0%)
net.html 633.42 KB 633.43 KB +8.00 B (+0.0%)
quic.html 924.12 KB 924.13 KB +3.00 B (+0.0%)
tls.html 523.79 KB 523.80 KB +3.00 B (+0.0%)

Performance estimate (single CI run)

  • Generation time: 0.2% faster (66.31 s → 66.16 s)
  • Peak memory: 13.0% lower (3.72 GB → 3.24 GB)

This branch was successfully deployed

1 active deployment
Preview – api-docs-tooling — 53d0744c Deployed Sep 29, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant