Skip to content

fix(security): avoid shell archive extraction - #31

Merged
mstuart merged 2 commits into
mainfrom
security/shell-free-installer-extraction
Sep 27, 2026
Merged

mstuart merged 2 commits into
mainfrom
security/shell-free-installer-extraction

Conversation

@mstuart

@mstuart mstuart commented Sep 27, 2026

Copy link
Copy Markdown
Owner

Summary

  • replace shell-interpolated tar/unzip commands with argument-array execution
  • add a regression test covering shell metacharacters in extraction paths
  • run installer tests in CI

Risk

Low. Archive names and extraction behavior are unchanged; only shell parsing is removed.

Verification

  • npm --prefix npm test
  • npm --prefix npm run check
  • cargo fmt -- --check
  • cargo clippy -- -D warnings
  • cargo test --lib (53 passed, 1 ignored)

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-27T22:05:59.898908Z aafce35 New commits
🔒 Security Review ✅ Completed 2026-09-27T21:09:25.050866Z a526721 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a52672118f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread npm/scripts/install.test.js
@mstuart
mstuart merged commit 4f03e27 into main Sep 27, 2026
3 checks passed
@mstuart
mstuart deleted the security/shell-free-installer-extraction branch September 27, 2026 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant