Make MessagePack and MessagePackUnpacker not serializable - #190
Open
nicolas-grekas wants to merge 1 commit into
Open
nicolas-grekas wants to merge 1 commit into
nicolas-grekas wants to merge 1 commit into
Conversation
Author
|
PR updated: before PHP 8.1, the classes now get the handlers that deny serialization, as suggested in phpredis/phpredis#2938, and the test runs on those versions too. |
nicolas-grekas
force-pushed
the
not-serializable
branch
from
September 30, 2026 05:52
8efe686 to
f4d2cec
Compare
serialize() lost their options and the buffer of unpackers, and unserialize() created objects without them. Both now throw, and so does msgpack_pack(): from PHP 8.1 on through the ZEND_ACC_NOT_SERIALIZABLE flag, which msgpack_pack() already honors, and before through the zend_class_(un)serialize_deny handlers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
serialize()loses the options ofMessagePackand the buffer ofMessagePackUnpacker, andunserialize()creates objects without them.This flags both classes as not serializable, so that
serialize(),unserialize()andmsgpack_pack(), which already honors the flag, throw. Other serializers that honor it, like symfony/php-ext-deepclone, then reject them too. Before PHP 8.1, which has no such flag, they get the handlers that deny serialization instead.