fix: replace Mono.zip with Mono.when in StdioServerTransportProvider#sendMessage - #981
Closed
neerajbhatt wants to merge 1 commit into
Closed
neerajbhatt wants to merge 1 commit into
neerajbhatt wants to merge 1 commit into
Conversation
…sendMessage Mono.zip requires actual values from each source to produce a Tuple2, but inboundReady and outboundReady are Sinks.One<Void> that only emit completion signals via tryEmitValue(null). This causes Mono.zip to never complete, hanging sendMessage. Mono.when correctly waits for completion signals without requiring values. Closes modelcontextprotocol#303
Contributor
Author
|
Closing as duplicate of #846 which already addresses this issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mono.zip()insendMessage()never completes becauseinboundReadyandoutboundReadyareSinks.One<Void>that emitnullviatryEmitValue(null)—ziprequires actual non-null values to produce aTuple2Mono.when()which correctly waits for completion signals without requiring valuesTest plan
StdioServerTransportProviderTestspassCloses #303