Repository navigation
test: approve a patch in the live app test - #47
Merged
Merged
Conversation
The app serves no patch until an operator approves one, so the live test failed at its first call against any current app. It now opens the issue, signs in as an operator and approves the clamp before the SDK calls, and covers aiohttp and urllib alongside httpx and requests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ What changed
MNFST_TEST_OPERATOR_EMAIL/_PASSWORD, defaulting to the dev seed.💭 Why
The app returns
no_patchuntil an operator approves a patch, sotest_live_app.pyfailed at its first call against any current app, whatever the SDK did.📝 Notes
mainbefore merging.mnfst/appmain. Still skipped in CI withoutMNFST_TEST_APP_URL.