Conversation
ianardee
force-pushed
the
rag-crud
branch
2 times, most recently
from
September 23, 2026 15:08
6d53eb5 to
d336659
Compare
ianardee
force-pushed
the
rag-crud
branch
2 times, most recently
from
September 29, 2026 19:53
5b06946 to
f217c04
Compare
ianardee
force-pushed
the
rag-crud
branch
2 times, most recently
from
September 29, 2026 20:57
1f892d2 to
0b79c98
Compare
ianardee
force-pushed
the
rag-crud
branch
5 times, most recently
from
September 30, 2026 08:40
ee914ac to
22ce934
Compare
ianardee
force-pushed
the
rag-crud
branch
3 times, most recently
from
September 30, 2026 10:15
0bb847d to
7586d59
Compare
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Polling validation and HTTP-client cleanup are broken, compatibility APIs are removed, and integration cleanup is unreliable.
Review effort: Balanced
Findings: 5
Open (5)
What changed in this PR
Adds V2 APIs for uploading, retrieving, annotating, polling, and deleting extraction RAG documents.
Changes:
- Adds RAG document models, parameters, HTTP operations, and lifecycle methods.
- Introduces registry-based inference and annotation field parsing.
- Updates serialization, response slugs, tests, and CI coverage.
| File | Description |
|---|---|
.github/workflows/_test-units.yml |
Reduces lite-test Python matrix. |
tests/v2/test_client.py |
Updates private HTTP client access. |
tests/v2/test_client_integration.py |
Uses typed field retrieval. |
tests/v2/test_base_classes.py |
Tests renamed product slug API. |
tests/v2/product/extraction/test_rag_documents.py |
Tests RAG parameters and parsing. |
tests/v2/product/extraction/test_rag_documents_integration.py |
Tests the RAG document lifecycle. |
tests/v2/product/extraction/test_extraction_response.py |
Updates public imports. |
tests/v2/input/test_inference_parameters.py |
Expects compact JSON serialization. |
mindee/v2/product/extraction/rag_documents/rag_annotation.py |
Defines RAG annotations. |
mindee/v2/product/extraction/rag_documents/params/rag_document_upload_parameters.py |
Defines upload parameters. |
mindee/v2/product/extraction/rag_documents/params/rag_document_annotation_parameters.py |
Defines annotation updates. |
mindee/v2/product/extraction/rag_documents/params/__init__.py |
Exports RAG parameters. |
mindee/v2/product/extraction/rag_documents/extraction_rag_annotation_response.py |
Parses extraction RAG responses. |
mindee/v2/product/extraction/rag_documents/annotated_simple_field.py |
Adds annotated simple fields. |
mindee/v2/product/extraction/rag_documents/annotated_object_field.py |
Adds annotated object fields. |
mindee/v2/product/extraction/rag_documents/annotated_list_field.py |
Adds annotated list fields. |
mindee/v2/product/extraction/rag_documents/annotated_fields.py |
Provides typed annotation lookup. |
mindee/v2/product/extraction/rag_documents/annotated_base_field.py |
Adds annotation field registry. |
mindee/v2/product/extraction/rag_documents/__init__.py |
Exports RAG document types. |
mindee/v2/product/extraction/params/data_schema.py |
Uses shared serialization types. |
mindee/v2/product/extraction/params/data_schema_replace.py |
Updates serializer import. |
mindee/v2/product/extraction/params/data_schema_field.py |
Updates serializer import. |
mindee/v2/product/extraction/params/__init__.py |
Removes serializer export. |
mindee/v2/product/extraction/extraction_result.py |
Uses registry-based field parsing. |
mindee/v2/product/extraction/extraction_response.py |
Removes redundant slug method. |
mindee/v2/product/extraction/__init__.py |
Removes serializer export. |
mindee/v2/parsing/string_data_class.py |
Produces compact JSON. |
mindee/v2/parsing/search/base_search_response.py |
Centralizes search response typing. |
mindee/v2/parsing/inference/field/simple_field.py |
Registers simple fields. |
mindee/v2/parsing/inference/field/object_field.py |
Registers and recursively parses objects. |
mindee/v2/parsing/inference/field/list_field.py |
Registers and parses list items. |
mindee/v2/parsing/inference/field/inference_fields.py |
Uses the field registry. |
mindee/v2/parsing/inference/field/factory.py |
Removes the legacy field factory. |
mindee/v2/parsing/inference/field/base_field.py |
Implements field registration and construction. |
mindee/v2/parsing/inference/base_inference_response.py |
Renames slug access and adds typing. |
mindee/v2/parsing/base_rag_annotation_response.py |
Adds the base RAG response model. |
mindee/v2/mindee_http/mindee_api_v2.py |
Adds RAG HTTP operations and caller helpers. |
mindee/v2/error/mindee_http_error_v2.py |
Logs structured HTTP errors. |
mindee/v2/client.py |
Exposes RAG lifecycle and polling APIs. |
mindee/v2/client_options/base_search_parameters.py |
Reuses shared search response typing. |
mindee/v2/client_options/base_rag_document_upload_parameters.py |
Adds base upload options. |
mindee/v2/client_options/base_product_parameters.py |
Clarifies file-closing documentation. |
mindee/v2/client_options/base_annotation_parameters.py |
Adds base annotation options. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
sebastianMindee
approved these changes
Sep 30, 2026
ianardee
added a commit
that referenced
this pull request
Oct 1, 2026
ianardee
added a commit
that referenced
this pull request
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Types of changes