Skip to content

Add "unstack all" to stack view - #8999

Merged
Alex Ross (alexr00) merged 2 commits into
alexr00/delighted-quailfrom
alexr00/cautious-marsupial
Oct 4, 2026
Merged

Alex Ross (alexr00) merged 2 commits into
alexr00/delighted-quailfrom
alexr00/cautious-marsupial

Conversation

@alexr00

Copy link
Copy Markdown
Member

No description provided.

@alexr00 Alex Ross (alexr00) self-assigned this Oct 1, 2026
@alexr00
Alex Ross (alexr00) added this pull request to stack #8993 October 1, 2026 14:20
@alexr00
Alex Ross (alexr00) force-pushed the alexr00/cautious-marsupial branch from 05dc8b3 to 4a7302e Compare October 1, 2026 14:23
@alexr00
Alex Ross (alexr00) removed this pull request from stack #8993 October 1, 2026 14:33
@alexr00
Alex Ross (alexr00) added this pull request to stack #9001 October 1, 2026 14:35
@alexr00
Alex Ross (alexr00) requested a balanced review from Copilot October 1, 2026 14:36

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The destructive operation has a stale-stack race, and the nested action control introduces an accessibility issue.

Review effort: Balanced
Findings: 2 Medium severity · 1 Low severity

Open (3)
What changed in this PR

Adds an “Unstack all” action to pull request stack views, backed by the GitHub stacks API.

Changes:

  • Adds permission-aware unstack UI, confirmation, errors, and responsive styling.
  • Implements unstack API handling and refreshes affected panels.
  • Adds coverage for API responses, permissions, cancellation, and panel refreshes.
File Description
webviews/​editorWebview/​test/​overview.test.tsx Tests unstack UI and errors.
webviews/​editorWebview/​index.css Styles stack actions and errors.
webviews/​components/​pullRequestStack.tsx Adds the unstack action.
webviews/​common/​context.tsx Exposes unstack messaging.
src/​view/​prsTreeDataProvider.ts Refreshes panels after stacking.
src/​test/​view/​prsTree.test.ts Tests stack panel refreshes.
src/​test/​mocks/​queryProvider.ts Supports mocked HTTP statuses.
src/​test/​github/​pullRequestOverview.test.ts Tests unstack orchestration.
src/​test/​github/​pullRequestModel.test.ts Tests unstack API behavior.
src/​github/​views.ts Defines the unstack result type.
src/​github/​pullRequestOverview.ts Handles confirmation and refreshes.
src/​github/​githubRepository.ts Calls the GitHub unstack endpoint.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/github/pullRequestOverview.ts Outdated
Comment thread webviews/components/pullRequestStack.tsx Outdated
Comment thread src/github/pullRequestOverview.ts Outdated
@alexr00
Alex Ross (alexr00) removed this pull request from stack #9001 October 2, 2026 18:51
@alexr00
Alex Ross (alexr00) force-pushed the alexr00/cautious-marsupial branch from ce036cc to 90ec9cc Compare October 3, 2026 10:11
@alexr00
Alex Ross (alexr00) added this pull request to stack #9012 October 3, 2026 10:39
@alexr00
Alex Ross (alexr00) marked this pull request as ready for review October 3, 2026 10:40
Copilot AI balanced review requested due to automatic review settings October 3, 2026 10:40

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The implementation is cohesive and comprehensively tested; the remaining grammar issue is non-blocking.

Review effort: Balanced
Findings: 1 Low severity

Open (1)
Resolved since last review (3)

Comment on lines +1146 to +1150
if (remainingPullRequests.length === stack.size) {
void vscode.window.showInformationMessage(vscode.l10n.t('No pull requests were unstacked. Merged, queued, or currently merging pull requests remain in the stack.'));
} else {
void vscode.window.showInformationMessage(vscode.l10n.t('Eligible pull requests unstacked. {0} merged, queued, or currently merging pull requests remain in the stack.', remainingPullRequests.length));
}
@alexr00
Alex Ross (alexr00) merged commit 9cb962b into main Oct 4, 2026
7 checks passed
@alexr00
Alex Ross (alexr00) deleted the alexr00/cautious-marsupial branch October 4, 2026 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants