Conversation
Contributor
|
I think @majst01 insisted on special variable naming. 😅 https://github.com/metal-stack/mini-lab/blob/master/Makefile#L438-L445 |
Gerrit91
reviewed
Sep 30, 2026
Gerrit91
left a comment
Gerrit91
left a comment
Contributor
There was a problem hiding this comment.
Sorry, I was mistaken, this PR would just overwrite the client env var when it is set. So this should be good to go.
| func NewRootCmd(c *config.Config) *cobra.Command { | ||
| viper.SetEnvPrefix(strings.ToUpper(config.ConfigDir)) | ||
| viper.SetEnvKeyReplacer(strings.NewReplacer("-", "_")) | ||
| viper.AutomaticEnv() |
Contributor
There was a problem hiding this comment.
Maybe we can just whitelist specific flags where it makes sense, otherwise I have the feeling this could lead to behavior that can be sometimes unexpected.
After flag definition we could do:
viper.MustBindEnv("config")
viper.MustBindEnv("force-color")
viper.MustBindEnv("debug")
viper.MustBindEnv("timeout")
viper.MustBindEnv("api-url")
viper.MustBindEnv("api-token")
Gerrit91
approved these changes
Oct 2, 2026
Gerrit91
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Example:
before:
(btw, the error message is misleading, setting METAL_APIV2_URL leads to another strange error)
with this PR: